A11Y: Do not use positive tabindex in composer (PR #12563)

From our audit:

Because positive number tabindex values have been used on the textarea, category and tags comboboxes, create topic button, cancel button, and Create a new Topic button, they have been forced to the start of the keyboard focus order on any page they’re on. The editor toolbar buttons, the fullscreen button, the minimize button, and the hide preview link do not have positive tab index values, but are at the end of the document and therefore last in the focus order.

In practical terms, this means that all of the focusable elements on the page are between the textarea and the editor toolbar buttons, making it a practical impossibility for a keyboard user to interact with these buttons. As screen reader users will enter forms mode while interacting with the textarea and other form elements, they are likely to be using the TAB key to navigate the composer widget just like other keyboard users. Unless they are aware of the editor toolbar buttons and other controls, screen reader users may not find them either.

Positive tabindex values should be avoided, instead allow the order of elements within the DOM determine the tab order.

GitHub