add GitHub commit onebox (PR #629)

This will change this link: https://github.com/discourse/discourse/commit/ee76f1926defa8309b3a7ea64a25707519529a13 into the following onebox:

Screenshot_03_04_13_03_23

Feedbacks much appreciated :wink:

GitHub

You’ve signed the CLA, ZogStriP. Thank you! This pull request is ready for review.

yay … thanks !!!

On Wed, Apr 3, 2013 at 12:38 PM, discoursebot notifications@github.comwrote:

You’ve signed the CLA, ZogStriP. Thank you! This pull request is ready for review.

— Reply to this email directly or view it on GitHubhttps://github.com/discourse/discourse/pull/629#issuecomment-15813151 .

only mild change I would possibly make is show a bit of the diff if possible with a show more button.

what about when there are several files? Should I show the diff of the first one?

I would cap it at a number of lines, say show a max of 80 lines of diff … with a more button. you need to cover the case where there are 10000 changes in one file.

On Wed, Apr 3, 2013 at 12:47 PM, Régis Hanol notifications@github.comwrote:

what about when there are several files? Should I show the diff of the first one?

— Reply to this email directly or view it on GitHubhttps://github.com/discourse/discourse/pull/629#issuecomment-15813389 .

Sure. My question should have been: is it ok to preview only the first X changes of the first file when several files are changed?

I think so, as long as a clear “show more” button is at the bottom.

On Wed, Apr 3, 2013 at 12:49 PM, Régis Hanol notifications@github.comwrote:

Sure. My question should have been: is it ok to preview only the first X changes of the first file when several files are changed?

— Reply to this email directly or view it on GitHubhttps://github.com/discourse/discourse/pull/629#issuecomment-15813438 .

Ok, I’ll do that tomorrow then. Going to :sleeping: now.

K … yanking this in for now :+1: