Correct flaky spec

approved
heisentest
#1

Correct flaky spec

Can fail if the machine running tests has less that 10% free space

diff --git a/spec/jobs/pull_hotlinked_images_spec.rb b/spec/jobs/pull_hotlinked_images_spec.rb
index 566b37f..2b37f3a 100644
--- a/spec/jobs/pull_hotlinked_images_spec.rb
+++ b/spec/jobs/pull_hotlinked_images_spec.rb
@@ -82,6 +82,7 @@ describe Jobs::PullHotlinkedImages do
       end
 
       it 'replaces image src' do
+        SiteSetting.download_remote_images_threshold = 0
         post = Fabricate(:post, raw: "#{url}")
 
         Jobs::ProcessPost.new.execute(post_id: post.id)

GitHub sha: 936582b8

#2

I remember this old gem, was so non-obvious.

1 Like
Approved #3