DEV: Add default on encoding to dir-span (PR #14183)

This is a follow up commit to:

75b0d6df93e1fd99a87195487b0de12533ec909f

Adds encoding of the input text passed into the dir-span helper so that it is on by default. This way any new implementations of dir-span will be encoded. Most of the uses of dir-span already have encoding so this includes a new optional parameter to disable the encoding if the input being passed in is already encoded.

GitHub

Thank you for this change :+1:

1 Like

Sorry revisit an already approved and merged PR, but I dislike having unnamed boolean parameters. It’s really not clear to me from the call site what this parameter is doing. Could you change it to be escape="false" or perhaps even htmlSafe="true"

Yep, I’ll do that. I like that much better as well. Thanks for the input :slight_smile:

1 Like