DEV: Add notification_types table (PR #8085)

This table stores the ids of the notfication types so that notification types can be added by plugins.

GitHub

You’ve signed the CLA, danielwaterworth. Thank you! This pull request is ready for review.

I am very mixed on this, the current approach of requiring plugins to submit a PR to core solves this. I don’t really see anything hugely problematic with this approach.

It gets confusing if id 22 on one db means something and another something else. Current approach gives us parity across instances.

There is a related discussion here:

This is a draft to demonstrate one approach. Personally I don’t think it’s worth the added complexity at this point. It’s mostly solving a problem we don’t have right now.

1 Like