DEV: Added support for custom site setting 'emoji_list' (PR #12414)

We need to show up/down buttons on mobile all the time (there’s no hover):

Capture d’écran 2021-04-06 à 10 43 27

I tested it on mobile:

  • first click buttons will be visible
  • second click picker will be opened

Do we need to change this behavior?

We need to show up/down buttons on mobile all the time (there’s no hover): Capture d’écran 2021-04-06 à 10 43 27

I tested it on mobile:

  • first click buttons will be visible
  • second click picker will be opened

Do we need to change this behavior?

Yes always show on mobile please, that’s too complicated. And first click on input should open picker

@jjaffeux Added the button instead of a textbox and + button.

@jjaffeux Added the button instead of a textbox and + button.

Screen.Recording.2021-04-07.at.12.39.20.PM.mov

Text should say Add reaction not emoji

@jjaffeux Added the button instead of a textbox and + button.

Screen.Recording.2021-04-07.at.12.39.20.PM.mov

why does the emoji disappears when we click on input? 12/13s on the video

@jjaffeux Added the button instead of a textbox and + button.

Screen.Recording.2021-04-07.at.12.39.20.PM.mov

Text should say Add reaction not emoji

We are making this setting for general use, if we say Add reaction is becomes specific to reactions plugin no?

@jjaffeux Added the button instead of a textbox and + button.

Screen.Recording.2021-04-07.at.12.39.20.PM.mov

why does the emoji disappears when we click on input? 12/13s on the video

I did that to show the user you are in the edit mode.

@jjaffeux Added the button instead of a textbox and + button.

Screen.Recording.2021-04-07.at.12.39.20.PM.mov

@jjaffeux Added the button instead of a textbox and + button.

Screen.Recording.2021-04-07.at.12.39.20.PM.mov

Text should say Add reaction not emoji

We are making this setting for general use, if we say Add reaction is becomes specific to reactions plugin no?

Yes I keep forgetting we are in core, ok leave it like this. :+1:

@jjaffeux Added the button instead of a textbox and + button.

Screen.Recording.2021-04-07.at.12.39.20.PM.mov

why does the emoji disappears when we click on input? 12/13s on the video

I did that to show the user you are in the edit mode.

I don’t think that’s necessary, or at least a good way to show it

@jjaffeux Added the button instead of a textbox and + button.

Screen.Recording.2021-04-07.at.12.39.20.PM.mov

why does the emoji disappears when we click on input? 12/13s on the video

I did that to show the user you are in the edit mode.

I don’t think that’s necessary, or at least a good way to show it

Okay, I’ll remove it :sweat_smile:

@jjaffeux removed the above behavior