DEV: adds event_reminder (27) and event_invitation (28) (#10473)

DEV: adds event_reminder (27) and event_invitation (28) (#10473)

Note that these events are also added to the list of events sent to push notifications.

diff --git a/app/models/notification.rb b/app/models/notification.rb
index b01ed3d..8b731c5 100644
--- a/app/models/notification.rb
+++ b/app/models/notification.rb
@@ -113,6 +113,8 @@ class Notification < ActiveRecord::Base
                         bookmark_reminder: 24,
                         reaction: 25,
                         votes_released: 26,
+                        event_reminder: 27,
+                        event_invitation: 28
                        )
   end
 
diff --git a/app/services/post_alerter.rb b/app/services/post_alerter.rb
index b746112..6b497b0 100644
--- a/app/services/post_alerter.rb
+++ b/app/services/post_alerter.rb
@@ -199,9 +199,18 @@ class PostAlerter
     end
   end
 
-  NOTIFIABLE_TYPES = [:mentioned, :replied, :quoted, :posted, :linked, :private_message, :group_mentioned, :watching_first_post].map { |t|
-    Notification.types[t]
-  }
+  NOTIFIABLE_TYPES = [
+    :mentioned,
+    :replied,
+    :quoted,
+    :posted,
+    :linked,
+    :private_message,
+    :group_mentioned,
+    :watching_first_post,
+    :event_reminder,
+    :event_invitation
+  ].map { |t| Notification.types[t] }
 
   def group_stats(topic)
     sql = <<~SQL
diff --git a/spec/models/notification_spec.rb b/spec/models/notification_spec.rb
index 740bf8e..1bde8f4 100644
--- a/spec/models/notification_spec.rb
+++ b/spec/models/notification_spec.rb
@@ -19,12 +19,35 @@ describe Notification do
         @types = Notification.types
       end
 
-      it "'mentioned' should be at 1st position" do
+      it "has a correct position for each type" do
         expect(@types[:mentioned]).to eq(1)
-      end
-
-      it "'group_mentioned' should be at 15th position" do
+        expect(@types[:replied]).to eq(2)
+        expect(@types[:quoted]).to eq(3)
+        expect(@types[:edited]).to eq(4)
+        expect(@types[:liked]).to eq(5)
+        expect(@types[:private_message]).to eq(6)
+        expect(@types[:invited_to_private_message]).to eq(7)
+        expect(@types[:invitee_accepted]).to eq(8)
+        expect(@types[:posted]).to eq(9)
+        expect(@types[:moved_post]).to eq(10)
+        expect(@types[:linked]).to eq(11)
+        expect(@types[:granted_badge]).to eq(12)
+        expect(@types[:invited_to_topic]).to eq(13)
+        expect(@types[:custom]).to eq(14)
         expect(@types[:group_mentioned]).to eq(15)
+        expect(@types[:group_message_summary]).to eq(16)
+        expect(@types[:watching_first_post]).to eq(17)
+        expect(@types[:topic_reminder]).to eq(18)
+        expect(@types[:liked_consolidated]).to eq(19)
+        expect(@types[:post_approved]).to eq(20)
+        expect(@types[:code_review_commit_approved]).to eq(21)
+        expect(@types[:membership_request_accepted]).to eq(22)
+        expect(@types[:membership_request_consolidated]).to eq(23)
+        expect(@types[:bookmark_reminder]).to eq(24)
+        expect(@types[:reaction]).to eq(25)
+        expect(@types[:votes_released]).to eq(26)
+        expect(@types[:event_reminder]).to eq(27)
+        expect(@types[:event_invitation]).to eq(28)
       end
     end
   end

GitHub sha: dde3d63b

This commit appears in #10473 which was approved by ZogStriP. It was merged by jjaffeux.