DEV: Allows server_plugin_outlet to use local variable (PR #12598)

[Ahmedgagan]

@jjaffeux @SamSaffron

GitHub

[SamSaffron]

@jjaffeux what is the context here?

[SamSaffron]

app/helpers/application_helper.rb

@@ -390,7 +389,19 @@ def server_plugin_outlet(name)
     return "" if erbs.blank?
 
     result = +""
-    erbs.each { |erb| result << render(inline: File.read(erb)) }
+    unless var

not sure if we are going to merge this, but we certainly should never ever do unless ... else … if ... else is far less confusing.

[SamSaffron]

app/helpers/application_helper.rb

@@ -390,7 +389,19 @@ def server_plugin_outlet(name)
     return "" if erbs.blank?
 
     result = +""
-    erbs.each { |erb| result << render(inline: File.read(erb)) }
+    unless var
+      erbs.each { |erb| result << render(inline: File.read(erb)) }
+    else
+      erbs.each do |erb|
+        file_name = erb.split("/").last
+
+        file_name = file_name.slice((file_name.index("_") + 1)..-1)
+        paths = erb.split("views")
+
+        result << render("/connectors/#{name}/#{file_name}", object: var)

something about the code her fees fragile.

[SamSaffron]

also must have a test for this key functionality.

[Ahmedgagan]

@jjaffeux what is the context here?

In server_plugin_outlet we can not pass the data to the view because inline render does not use passed local data. So, I did these changes to pass the data to the views using server_plugin_outlets.

I needed it to add a field in the embed topic view.

[SamSaffron]

I see, I assume we have a workaround for now. Going to close this.