DEV: apply ember-template-lint fixes (#53)

DEV: apply ember-template-lint fixes (#53)

diff --git a/assets/javascripts/discourse/templates/admin/plugins-patreon.hbs b/assets/javascripts/discourse/templates/admin/plugins-patreon.hbs
index 86cef84..eaff747 100644
--- a/assets/javascripts/discourse/templates/admin/plugins-patreon.hbs
+++ b/assets/javascripts/discourse/templates/admin/plugins-patreon.hbs
@@ -1,45 +1,53 @@
 <section id="patreon">
   <h1>{{i18n "patreon.header.rules"}}</h1>
   <table>
-    <tr>
-      <th>{{i18n "patreon.group"}}</th>
-      <th>{{i18n "patreon.rewards"}}</th>
-      <th></th>
-    </tr>
+    <thead>
+      <tr>
+        <th>{{i18n "patreon.group"}}</th>
+        <th>{{i18n "patreon.rewards"}}</th>
+        <th></th>
+      </tr>
+    </thead>
+
+    <tbody>
+      {{#each model as |rule|}}
+        <tr class="">
+          <td>{{rule.group}}</td>
+          <td>{{rule.rewards}}</td>
+          <td>
+            <div class="pull-right">
+              {{d-button action="delete" actionParam=rule icon="far-trash-alt" class="delete btn-danger" title="patreon.delete"}}
+            </div>
+          </td>
+        </tr>
+      {{/each}}
+    </tbody>
 
-    {{#each model as |rule|}}
-      <tr class="">
-        <td>{{rule.group}}</td>
-        <td>{{rule.rewards}}</td>
+    <tfoot>
+      <tr class="new-filter">
+        <td>{{combo-box value=editing.group_id content=groups nameProperty="name" valueProperty="id" none="patreon.select_group"}}</td>
+        <td>{{list-setting value=editing.reward_list choices=rewardsNames class="rewards"}}</td>
         <td>
           <div class="pull-right">
-            {{d-button action="delete" actionParam=rule icon="far-trash-alt" class="delete btn-danger" title="patreon.delete"}}
+            {{d-button action="save" icon="check" class="save btn-primary" title="patreon.save"}}
           </div>
         </td>
       </tr>
-    {{/each}}
-
-    <tr class="new-filter">
-      <td>{{combo-box value=editing.group_id content=groups nameProperty="name" valueProperty="id" none="patreon.select_group"}}</td>
-      <td>{{list-setting value=editing.reward_list choices=rewardsNames class="rewards"}}</td>
-      <td>
-        <div class="pull-right">
-          {{d-button action="save" icon="check" class="save btn-primary" title="patreon.save"}}
-        </div>
-      </td>
-    </tr>
+    </tfoot>
   </table>
 
   <p>{{i18n "patreon.help_text"}}</p>
 
-  {{d-button action="updateData"
+  {{d-button
+    action="updateData"
     icon="refresh"
     class="test"
     disabled=updatingData
     title="patreon.update_data"
-    label="patreon.update_data"}}
+    label="patreon.update_data"
+  }}
 
   {{#if last_sync_at}}
-    <span class="last_synced">{{i18n "patreon.last_synced"}}: {{{format-date last_sync_at leaveAgo="true"}}}</span>
+    <span class="last_synced">{{i18n "patreon.last_synced"}}: {{html-safe format-date last_sync_at leaveAgo="true"}}</span>
   {{/if}}
 </section>
diff --git a/assets/javascripts/discourse/templates/connectors/admin-user-details/patreon.hbs b/assets/javascripts/discourse/templates/connectors/admin-user-details/patreon.hbs
index 94921b1..b83ce3b 100644
--- a/assets/javascripts/discourse/templates/connectors/admin-user-details/patreon.hbs
+++ b/assets/javascripts/discourse/templates/connectors/admin-user-details/patreon.hbs
@@ -1,52 +1,56 @@
-<section class='details'>
-  <h1>{{i18n 'patreon.title'}}</h1>
-  <div class='display-row'>
-    <div class='field'>{{i18n 'patreon.field.id'}}</div>
-    <div class='value'>{{model.patreon_id}}</div>
+<section class="details">
+  <h1>{{i18n "patreon.title"}}</h1>
+  <div class="display-row">
+    <div class="field">{{i18n "patreon.field.id"}}</div>
+    <div class="value">{{model.patreon_id}}</div>
   </div>
   {{#if model.patreon_email_exists}}
-  <div class='display-row'>
-    <div class='field'>{{i18n 'patreon.field.email'}}</div>
-    <div class='value'>
-      {{#if patreon_email}}
-        {{patreon_email}}
-      {{else}}
-        {{d-button
-          class="btn-default"
-          action="checkPatreonEmail"
-          actionParam=model icon="far-envelope"
-          label="admin.users.check_email.text"
-          title="admin.users.check_email.title"}}
-      {{/if}}
+    <div class="display-row">
+      <div class="field">{{i18n "patreon.field.email"}}</div>
+      <div class="value">
+        {{#if patreon_email}}
+          {{patreon_email}}
+        {{else}}
+          {{d-button
+            class="btn-default"
+            action="checkPatreonEmail"
+            actionParam=model icon="far-envelope"
+            label="admin.users.check_email.text"
+            title="admin.users.check_email.title"}}
+        {{/if}}
+      </div>
     </div>
-  </div>
   {{/if}}
   {{#if model.patreon_amount_cents}}
-  <div class='display-row'>
-    <div class='field'>{{i18n 'patreon.field.amount_cents'}}</div>
-    <div class='value'>{{model.patreon_amount_cents}}</div>
-  </div>
+    <div class="display-row">
+      <div class="field">{{i18n "patreon.field.amount_cents"}}</div>
+      <div class="value">{{model.patreon_amount_cents}}</div>
+    </div>
   {{/if}}
   {{#if model.patreon_rewards}}
-  <div class='display-row'>
-    <div class='field'>{{i18n 'patreon.field.rewards'}}</div>
-    <div class='value'>{{model.patreon_rewards}}</div>
-  </div>
+    <div class="display-row">
+      <div class="field">{{i18n "patreon.field.rewards"}}</div>
+      <div class="value">{{model.patreon_rewards}}</div>
+    </div>
   {{/if}}
   {{#if model.patreon_declined_since}}
-  <div class='display-row'>
-    <div class='field'>{{i18n 'patreon.field.declined_since'}}</div>
-    <div class='value'>{{{format-date model.patreon_declined_since}}}</div>
-  </div>
+    <div class="display-row">
+      <div class="field">{{i18n "patreon.field.declined_since"}}</div>
+      <div class="value">{{html-safe format-date model.patreon_declined_since}}</div>
+    </div>
   {{/if}}
-  <div class='display-row'>
-    <div class='field'>{{i18n 'patreon.field.more_details.label'}}</div>
-    <div class='value'><a target="_blank" href="{{patron_url}}">{{d-icon 'external-link-alt'}}</a></div>
+  <div class="display-row">
+    <div class="field">{{i18n "patreon.field.more_details.label"}}</div>
+    <div class="value">
+      <a rel="noopener noreferrer" target="_blank" href={{patron_url}}>
+        {{d-icon "external-link-alt"}}
+      </a>
+    </div>
     <div class="controls">
       {{#if model.patreon_email}}
-        {{i18n 'patreon.field.more_details.help_text.email_available'}}
+        {{i18n "patreon.field.more_details.help_text.email_available"}}
       {{else}}
-        {{i18n 'patreon.field.more_details.help_text.email_not_available'}}
+        {{i18n "patreon.field.more_details.help_text.email_not_available"}}
       {{/if}}
     </div>
   </div>
diff --git a/assets/javascripts/discourse/templates/connectors/topic-above-footer-buttons/patreon.hbs b/assets/javascripts/discourse/templates/connectors/topic-above-footer-buttons/patreon.hbs
index d98f586..fdf5282 100644
--- a/assets/javascripts/discourse/templates/connectors/topic-above-footer-buttons/patreon.hbs
+++ b/assets/javascripts/discourse/templates/connectors/topic-above-footer-buttons/patreon.hbs
@@ -1,10 +1,9 @@
 {{#if showDonationPrompt}}
   <div class="patreon-donation-prompt">
-    <span class="close" {{action "close"}}>
+    <span role="button" class="close" {{action "close"}}>
       {{d-icon "times"}}
     </span>
 
-    {{{i18n "patreon.donation_prompt.body"
-      campaignUrl=siteSettings.patreon_donation_prompt_campaign_url}}}
+    {{html-safe (i18n "patreon.donation_prompt.body" campaignUrl=siteSettings.patreon_donation_prompt_campaign_url)}}
   </div>
 {{/if}}

GitHub sha: 3941f3cd

This commit appears in #53 which was approved by CvX. It was merged by jjaffeux.