DEV: Correct DeprecatedSettings test cleanup (#12177)

discourse
,
#1

DEV: Correct DeprecatedSettings test cleanup (#12177)

If this test ran before the new SiteSettingsController spec from 8cd7c9b2593462ad64512ac7e4bd208a4d560fa3, it would fail the run. We need to dup the array before calling .clear on the original

diff --git a/spec/models/site_setting_spec.rb b/spec/models/site_setting_spec.rb
index 9b87678..cf9b517 100644
--- a/spec/models/site_setting_spec.rb
+++ b/spec/models/site_setting_spec.rb
@@ -163,7 +163,7 @@ describe SiteSetting do
 
     it 'should act as a proxy to the new methods' do
       begin
-        original_settings = SiteSettings::DeprecatedSettings::SETTINGS
+        original_settings = SiteSettings::DeprecatedSettings::SETTINGS.dup
         SiteSettings::DeprecatedSettings::SETTINGS.clear
 
         SiteSettings::DeprecatedSettings::SETTINGS.push([

GitHub sha: 063690d2

#2
#3

This commit appears in #12177 which was approved by CvX. It was merged by davidtaylorhq.