DEV: Correct DeprecatedSettings test cleanup (PR #12177)

discourse
#1

If this test ran before the new SiteSettingsController spec from 8cd7c9b2593462ad64512ac7e4bd208a4d560fa3, it would fail the run. We need to dup the array before calling .clear on the original

GitHub

#2
#3