You’ve signed the CLA, vinothkannans. Thank you! This pull request is ready for review.
I worry we are sitting on this for so long, is this ready to merge?
@SamSaffron it is ready to merge.
This looks quite good to me. Maybe @OsamaSayegh can also have a look at this and review cause he is super familiar with this system.
The only minor thing I am seeing here (which is not new) is the name
asset_name is quite confusing imo, maybe we should call it
plugin_directory_name to be explicit or something else?
asset_name is now renamed to
plugin_directory_name. And I added a minor fix too. cc @OsamaSayegh
This pull request has been mentioned on Discourse Meta. There might be relevant details there: