DEV: disable emoji-picker test to attempt to fix timeouts (#7754)

approved
#1

DEV: disable emoji-picker test to attempt to fix timeouts (#7754)

diff --git a/test/javascripts/acceptance/emoji-picker-test.js.es6 b/test/javascripts/acceptance/emoji-picker-test.js.es6
index 34cd474..1c17b32 100644
--- a/test/javascripts/acceptance/emoji-picker-test.js.es6
+++ b/test/javascripts/acceptance/emoji-picker-test.js.es6
@@ -1,164 +1,164 @@
-import { acceptance } from "helpers/qunit-helpers";
-import { IMAGE_VERSION as v } from "pretty-text/emoji/version";
-import { resetCache } from "discourse/components/emoji-picker";
-
-acceptance("EmojiPicker", {
-  loggedIn: true,
-  beforeEach() {
-    resetCache();
-  }
-});
-
-QUnit.skip("emoji picker can be opened/closed", async assert => {
-  await visit("/t/internationalization-localization/280");
-  await click("#topic-footer-buttons .btn.create");
-
-  await click("button.emoji.btn");
-  assert.notEqual(
-    find(".emoji-picker")
-      .html()
-      .trim(),
-    "",
-    "it opens the picker"
-  );
-
-  await click("button.emoji.btn");
-  assert.equal(
-    find(".emoji-picker")
-      .html()
-      .trim(),
-    "",
-    "it closes the picker"
-  );
-});
-
-QUnit.test("emojis can be hovered to display info", async assert => {
-  await visit("/t/internationalization-localization/280");
-  await click("#topic-footer-buttons .btn.create");
-
-  await click("button.emoji.btn");
-  $(".emoji-picker button[title='grinning']").trigger("mouseover");
-  assert.equal(
-    find(".emoji-picker .info")
-      .html()
-      .trim(),
-    `<img src=\"/images/emoji/emoji_one/grinning.png?v=${v}\" class=\"emoji\"> <span>:grinning:<span></span></span>`,
-    "it displays emoji info when hovering emoji"
-  );
-});
-
-QUnit.test("emoji picker triggers event when picking emoji", async assert => {
-  await visit("/t/internationalization-localization/280");
-  await click("#topic-footer-buttons .btn.create");
-  await click("button.emoji.btn");
-
-  await click(".emoji-picker button[title='grinning']");
-  assert.equal(
-    find(".d-editor-input").val(),
-    ":grinning:",
-    "it adds the emoji code in the editor when selected"
-  );
-});
-
-QUnit.test("emoji picker has a list of recently used emojis", async assert => {
-  await visit("/t/internationalization-localization/280");
-  await click("#topic-footer-buttons .btn.create");
-  await click("button.emoji.btn");
-
-  await click(
-    ".emoji-picker .section[data-section='smileys_&_emotion'] button.emoji[title='grinning']"
-  );
-  assert.equal(
-    find('.emoji-picker .section[data-section="recent"]').css("display"),
-    "block",
-    "it shows recent section"
-  );
-
-  assert.equal(
-    find(
-      '.emoji-picker .section[data-section="recent"] .section-group button.emoji'
-    ).length,
-    1,
-    "it adds the emoji code to the recently used emojis list"
-  );
-
-  await click(".emoji-picker .clear-recent");
-  assert.equal(
-    find(
-      '.emoji-picker .section[data-section="recent"] .section-group button.emoji'
-    ).length,
-    0,
-    "it has cleared recent emojis"
-  );
-
-  assert.equal(
-    find('.emoji-picker .section[data-section="recent"]').css("display"),
-    "none",
-    "it hides recent section"
-  );
-
-  assert.equal(
-    find('.emoji-picker .category-icon button.emoji[data-section="recent"]')
-      .parent()
-      .css("display"),
-    "none",
-    "it hides recent category icon"
-  );
-});
-
-QUnit.test(
-  "emoji picker correctly orders recently used emojis",
-  async assert => {
-    await visit("/t/internationalization-localization/280");
-    await click("#topic-footer-buttons .btn.create");
-
-    await click("button.emoji.btn");
-    await click(".emoji-picker button[title='sunglasses']");
-    await click(".emoji-picker button[title='grinning']");
-    assert.equal(
-      find('.section[data-section="recent"] .section-group button.emoji')
-        .length,
-      2,
-      "it has multiple recent emojis"
-    );
-
-    assert.equal(
-      /grinning/.test(
-        find('.section[data-section="recent"] .section-group button.emoji')
-          .first()
-          .css("background-image")
-      ),
-      true,
-      "it puts the last used emoji in first"
-    );
-  }
-);
-
-QUnit.test("emoji picker lazy loads emojis", async assert => {
-  await visit("/t/internationalization-localization/280");
-  await click("#topic-footer-buttons .btn.create");
-
-  await click("button.emoji.btn");
-
-  assert.equal(
-    find('.emoji-picker button[title="massage_woman"]').css("background-image"),
-    "none",
-    "it doesn't load invisible emojis"
-  );
-});
-
-QUnit.test("emoji picker persists state", async assert => {
-  await visit("/t/internationalization-localization/280");
-  await click("#topic-footer-buttons .btn.create");
-
-  await click("button.emoji.btn");
-  await click(".emoji-picker a.diversity-scale.medium-dark");
-  await click("button.emoji.btn");
-
-  await click("button.emoji.btn");
-  assert.equal(
-    find(".emoji-picker .diversity-scale.medium-dark").hasClass("selected"),
-    true,
-    "it stores diversity scale"
-  );
-});
+// import { acceptance } from "helpers/qunit-helpers";
+// import { IMAGE_VERSION as v } from "pretty-text/emoji/version";
+// import { resetCache } from "discourse/components/emoji-picker";
+//
+// acceptance("EmojiPicker", {
+//   loggedIn: true,
+//   beforeEach() {
+//     resetCache();
+//   }
+// });
+//
+// QUnit.test("emoji picker can be opened/closed", async assert => {
+//   await visit("/t/internationalization-localization/280");
+//   await click("#topic-footer-buttons .btn.create");
+//
+//   await click("button.emoji.btn");
+//   assert.notEqual(
+//     find(".emoji-picker")
+//       .html()
+//       .trim(),
+//     "",
+//     "it opens the picker"
+//   );
+//
+//   await click("button.emoji.btn");
+//   assert.equal(
+//     find(".emoji-picker")
+//       .html()
+//       .trim(),
+//     "",
+//     "it closes the picker"
+//   );
+// });
+//
+// QUnit.test("emojis can be hovered to display info", async assert => {
+//   await visit("/t/internationalization-localization/280");
+//   await click("#topic-footer-buttons .btn.create");
+//
+//   await click("button.emoji.btn");
+//   $(".emoji-picker button[title='grinning']").trigger("mouseover");
+//   assert.equal(
+//     find(".emoji-picker .info")
+//       .html()
+//       .trim(),
+//     `<img src=\"/images/emoji/emoji_one/grinning.png?v=${v}\" class=\"emoji\"> <span>:grinning:<span></span></span>`,
+//     "it displays emoji info when hovering emoji"
+//   );
+// });
+//
+// QUnit.test("emoji picker triggers event when picking emoji", async assert => {
+//   await visit("/t/internationalization-localization/280");
+//   await click("#topic-footer-buttons .btn.create");
+//   await click("button.emoji.btn");
+//
+//   await click(".emoji-picker button[title='grinning']");
+//   assert.equal(
+//     find(".d-editor-input").val(),
+//     ":grinning:",
+//     "it adds the emoji code in the editor when selected"
+//   );
+// });
+//
+// QUnit.test("emoji picker has a list of recently used emojis", async assert => {
+//   await visit("/t/internationalization-localization/280");
+//   await click("#topic-footer-buttons .btn.create");
+//   await click("button.emoji.btn");
+//
+//   await click(
+//     ".emoji-picker .section[data-section='smileys_&_emotion'] button.emoji[title='grinning']"
+//   );
+//   assert.equal(
+//     find('.emoji-picker .section[data-section="recent"]').css("display"),
+//     "block",
+//     "it shows recent section"
+//   );
+//
+//   assert.equal(
+//     find(
+//       '.emoji-picker .section[data-section="recent"] .section-group button.emoji'
+//     ).length,
+//     1,
+//     "it adds the emoji code to the recently used emojis list"
+//   );
+//
+//   await click(".emoji-picker .clear-recent");
+//   assert.equal(
+//     find(
+//       '.emoji-picker .section[data-section="recent"] .section-group button.emoji'
+//     ).length,
+//     0,
+//     "it has cleared recent emojis"
+//   );
+//
+//   assert.equal(

[... diff too long, it was truncated ...]

GitHub sha: 5da91fa8

Follow Up #2
#4

need a cleaner skip here.

#5
2 Likes
Approved #6