DEV: Fix flaky instagram onebox spec by not mutating constant. (PR #13853)

GitHub

Mutation was happening in discourse/engine.rb at c161f5e0b298fa6842b83d2bc4627b5a8f92aff0 · discourse/discourse · GitHub

What is the point of even having this in a const? Can’t we just do @options = {}?

Good point, let me remove it to see if tests fail. We don’t need to keep backwards compatibility with this constant anymore.

@martin-brennan Done :slight_smile:

Cool thanks. Just seems really weird to me to even make this into a const in the first place!