DEV: Include "_learn_more" key in theme `about.json`

DEV: Include “_learn_more” key in theme about.json

This does not serve any technical purpose. It is there to provide a signpost for any user/developer that wants to know what to do with a theme archive.

diff --git a/app/models/theme.rb b/app/models/theme.rb
index 39c2b9a..0abbbc7 100644
--- a/app/models/theme.rb
+++ b/app/models/theme.rb
@@ -454,6 +454,8 @@ class Theme < ActiveRecord::Base
         end
       end
 
+      meta[:_learn_more] = "https://meta.discourse.org/t/beginners-guide-to-using-discourse-themes/91966"
+
     end
   end
 end
diff --git a/spec/components/theme_store/tgz_exporter_spec.rb b/spec/components/theme_store/tgz_exporter_spec.rb
index 12dd763..eb3104e 100644
--- a/spec/components/theme_store/tgz_exporter_spec.rb
+++ b/spec/components/theme_store/tgz_exporter_spec.rb
@@ -88,7 +88,8 @@ describe ThemeStore::TgzExporter do
             "header_background": "1E1E1E",
             "tertiary": "858585"
           }
-        }
+        },
+        "_learn_more": "https://meta.discourse.org/t/beginners-guide-to-using-discourse-themes/91966"
       )
 
       expect(File.read("common/body_tag.html")).to eq("<b>testtheme1</b>")

GitHub sha: 033cd4f3

1 Like

This is bike shedding territory, but I think it should be learn_more. My thinking is that _ usually means “private” in Javascript like an implementation detail. In this case, we want the user the see it and check it out.

I guess I was thinking “_” because it isn’t actually part of the data - it’s meta-meta-data. Ideally it should be a comment, but JSON doesn’t allow that. Will remove the underscore :+1:

DEV: Remove underscore from `learn_more` key in theme export