DEV: lint files and update deps

DEV: lint files and update deps

This ensures rubocop runs as expected

Also updates a bunch of dependencies

diff --git a/.rubocop.yml b/.rubocop.yml
index 632263e..f704310 100644
--- a/.rubocop.yml
+++ b/.rubocop.yml
@@ -1,11 +1,5 @@
-inherit_from: https://raw.githubusercontent.com/discourse/discourse/master/.rubocop.yml
-
-# https://github.com/rubocop-hq/rubocop/issues/1518
-Lint/ShadowingOuterLocalVariable:
-  Enabled: false
-
-Layout/HashAlignment:
-  Enabled: false
+inherit_gem:
+  rubocop-discourse: default.yml
 
 RSpec/MessageSpies:
   Enabled: false
diff --git a/Gemfile b/Gemfile
index fdfb987..f462e38 100644
--- a/Gemfile
+++ b/Gemfile
@@ -13,6 +13,7 @@ gem 'frankenstein', '~> 0.1'
 gem 'pg'
 gem 'mini_sql'
 gem 'dns-sd'
+gem 'rubocop-discourse'
 
 group :development do
   gem 'byebug'
diff --git a/Gemfile.lock b/Gemfile.lock
index d2dd3e2..145d42e 100644
--- a/Gemfile.lock
+++ b/Gemfile.lock
@@ -1,43 +1,45 @@
 GEM
   remote: https://rubygems.org/
   specs:
-    ast (2.4.0)
-    aws-sdk (2.10.21)
-      aws-sdk-resources (= 2.10.21)
-    aws-sdk-core (2.10.21)
+    ast (2.4.1)
+    aws-eventstream (1.1.0)
+    aws-sdk (2.11.605)
+      aws-sdk-resources (= 2.11.605)
+    aws-sdk-core (2.11.605)
       aws-sigv4 (~> 1.0)
       jmespath (~> 1.0)
-    aws-sdk-resources (2.10.21)
-      aws-sdk-core (= 2.10.21)
-    aws-sigv4 (1.0.1)
-    azure_mgmt_dns (0.17.0)
-      ms_rest_azure (~> 0.11.0)
-    byebug (9.0.6)
-    coderay (1.1.1)
-    concurrent-ruby (1.0.5)
-    diff-lcs (1.3)
+    aws-sdk-resources (2.11.605)
+      aws-sdk-core (= 2.11.605)
+    aws-sigv4 (1.2.2)
+      aws-eventstream (~> 1, >= 1.0.2)
+    azure_mgmt_dns (0.17.5)
+      ms_rest_azure (~> 0.12.0)
+    byebug (11.1.3)
+    coderay (1.1.3)
+    concurrent-ruby (1.1.7)
+    diff-lcs (1.4.4)
     dns-sd (0.1.3)
-    docile (1.1.5)
-    docker-api (1.33.6)
-      excon (>= 0.38.0)
-      json
-    domain_name (0.5.20180417)
+    docile (1.3.2)
+    docker-api (1.34.2)
+      excon (>= 0.47.0)
+      multi_json
+    domain_name (0.5.20190701)
       unf (>= 0.0.5, < 1.0.0)
-    excon (0.59.0)
-    faraday (0.15.2)
+    excon (0.76.0)
+    faraday (1.0.1)
       multipart-post (>= 1.2, < 3)
-    faraday-cookie_jar (0.0.6)
-      faraday (>= 0.7.4)
+    faraday-cookie_jar (0.0.7)
+      faraday (>= 0.8.0)
       http-cookie (~> 1.0.0)
-    ffi (1.9.18)
+    ffi (1.13.1)
     formatador (0.2.5)
     frankenstein (0.3.1)
       prometheus-client (= 0.7.1)
       rack (~> 2.0)
-    guard (2.14.1)
+    guard (2.16.2)
       formatador (>= 0.2.4)
       listen (>= 2.7, < 4.0)
-      lumberjack (~> 1.0)
+      lumberjack (>= 1.0.12, < 2.0)
       nenv (~> 0.1)
       notiffany (~> 0.0)
       pry (>= 0.9.12)
@@ -53,93 +55,92 @@ GEM
       rubocop (~> 0.20)
     http-cookie (1.0.3)
       domain_name (~> 0.5)
-    jaro_winkler (1.5.4)
-    jmespath (1.3.1)
-    json (2.3.1)
-    listen (3.1.5)
-      rb-fsevent (~> 0.9, >= 0.9.4)
-      rb-inotify (~> 0.9, >= 0.9.7)
-      ruby_dep (~> 1.2)
-    lumberjack (1.0.12)
-    method_source (0.8.2)
-    mini_sql (0.1.10)
-    ms_rest (0.7.2)
+    jmespath (1.4.0)
+    listen (3.2.1)
+      rb-fsevent (~> 0.10, >= 0.10.3)
+      rb-inotify (~> 0.9, >= 0.9.10)
+    lumberjack (1.2.8)
+    method_source (1.0.0)
+    mini_sql (0.3)
+    ms_rest (0.7.6)
       concurrent-ruby (~> 1.0)
-      faraday (~> 0.9)
-      timeliness (~> 0.3)
-    ms_rest_azure (0.11.0)
+      faraday (>= 0.9, < 2.0.0)
+      timeliness (~> 0.3.10)
+    ms_rest_azure (0.12.0)
       concurrent-ruby (~> 1.0)
-      faraday (~> 0.9)
+      faraday (>= 0.9, < 2.0.0)
       faraday-cookie_jar (~> 0.0.6)
-      ms_rest (~> 0.7.2)
-    multipart-post (2.0.0)
+      ms_rest (~> 0.7.6)
+    multi_json (1.15.0)
+    multipart-post (2.1.1)
     nenv (0.3.0)
-    notiffany (0.1.1)
+    notiffany (0.1.3)
       nenv (~> 0.1)
       shellany (~> 0.0)
-    parallel (1.19.1)
-    parser (2.7.0.5)
-      ast (~> 2.4.0)
-    pg (1.1.3)
+    parallel (1.19.2)
+    parser (2.7.2.0)
+      ast (~> 2.4.1)
+    pg (1.2.3)
     prometheus-client (0.7.1)
       quantile (~> 0.2.0)
-    pry (0.10.4)
-      coderay (~> 1.1.0)
-      method_source (~> 0.8.1)
-      slop (~> 3.4)
-    pry-byebug (3.4.2)
-      byebug (~> 9.0)
-      pry (~> 0.10)
+    pry (0.13.1)
+      coderay (~> 1.1)
+      method_source (~> 1.0)
+    pry-byebug (3.9.0)
+      byebug (~> 11.0)
+      pry (~> 0.13.0)
     quantile (0.2.1)
     rack (2.2.3)
     rainbow (3.0.0)
-    rake (12.3.3)
-    rb-fsevent (0.10.2)
-    rb-inotify (0.9.10)
-      ffi (>= 0.5.0, < 2)
-    redcarpet (3.4.0)
+    rake (13.0.1)
+    rb-fsevent (0.10.4)
+    rb-inotify (0.10.1)
+      ffi (~> 1.0)
+    redcarpet (3.5.0)
+    regexp_parser (1.8.2)
     rexml (3.2.4)
-    rspec (3.6.0)
-      rspec-core (~> 3.6.0)
-      rspec-expectations (~> 3.6.0)
-      rspec-mocks (~> 3.6.0)
-    rspec-core (3.6.0)
-      rspec-support (~> 3.6.0)
-    rspec-expectations (3.6.0)
+    rspec (3.9.0)
+      rspec-core (~> 3.9.0)
+      rspec-expectations (~> 3.9.0)
+      rspec-mocks (~> 3.9.0)
+    rspec-core (3.9.3)
+      rspec-support (~> 3.9.3)
+    rspec-expectations (3.9.2)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.6.0)
-    rspec-mocks (3.6.0)
+      rspec-support (~> 3.9.0)
+    rspec-mocks (3.9.1)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.6.0)
-    rspec-support (3.6.0)
-    rubocop (0.81.0)
-      jaro_winkler (~> 1.5.1)
+      rspec-support (~> 3.9.0)
+    rspec-support (3.9.3)
+    rubocop (0.93.1)
       parallel (~> 1.10)
-      parser (>= 2.7.0.1)
+      parser (>= 2.7.1.5)
       rainbow (>= 2.2.2, < 4.0)
+      regexp_parser (>= 1.8)
       rexml
+      rubocop-ast (>= 0.6.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 1.4.0, < 2.0)
-    rubocop-discourse (2.0.1)
+    rubocop-ast (0.7.1)
+      parser (>= 2.7.1.5)
+    rubocop-discourse (2.3.2)
       rubocop (>= 0.69.0)
-    rubocop-rspec (1.38.1)
-      rubocop (>= 0.68.1)
+      rubocop-rspec (>= 1.39.0)
+    rubocop-rspec (1.43.2)
+      rubocop (~> 0.87)
     ruby-progressbar (1.10.1)
-    ruby_dep (1.5.0)
     shellany (0.0.1)
-    simplecov (0.14.1)
-      docile (~> 1.1.0)
-      json (>= 1.8, < 3)
-      simplecov-html (~> 0.10.0)
-    simplecov-html (0.10.1)
-    slop (3.6.0)
-    thor (0.19.4)
-    timeliness (0.3.8)
+    simplecov (0.19.0)
+      docile (~> 1.1)
+      simplecov-html (~> 0.11)
+    simplecov-html (0.12.3)
+    thor (1.0.1)
+    timeliness (0.3.10)
     unf (0.1.4)
       unf_ext
-    unf_ext (0.0.7.5)
+    unf_ext (0.0.7.7)
     unicode-display_width (1.7.0)
-    yard (0.9.16)
+    yard (0.9.25)
 
 PLATFORMS
   ruby
@@ -167,7 +168,7 @@ DEPENDENCIES
   yard
 
 RUBY VERSION
-   ruby 2.3.3p222
+   ruby 2.6.5p114
 
 BUNDLED WITH
-   2.1.2
+   2.1.4
diff --git a/lib/ddnssd/backend/azure.rb b/lib/ddnssd/backend/azure.rb
index 9195c7d..6afd433 100644
--- a/lib/ddnssd/backend/azure.rb
+++ b/lib/ddnssd/backend/azure.rb
@@ -80,15 +80,15 @@ class DDNSSD::Backend::Azure < DDNSSD::Backend
     end
 
     def dnssd_to_az_records(records)
-      r = records.first
+      first_record = records.first
       rrset = RecordSet.new
-      rrset.ttl = r.ttl
-      rrset.name = dnssd_to_az_name r.name
-      rrset.type = r.type.to_s
-      case r.type
-      when :A then rrset.arecords = records.map { |r|
+      rrset.ttl = first_record.ttl
+      rrset.name = dnssd_to_az_name first_record.name
+      rrset.type = first_record.type.to_s
+      case first_record.type
+      when :A then rrset.arecords = records.map { |record|
                       ar = ARecord.new
-                      ar.ipv4address = r.value
+                      ar.ipv4address = record.value
                       ar }
       when :AAAA then rrset.aaaa_records = records.map { |r|
                          ar = AaaaRecord.new
@@ -357,7 +357,7 @@ class DDNSSD::Backend::Azure < DDNSSD::Backend
         end
 
         ptrs = @record_cache.get(srv_rr.parent_name, :PTR)
-        ptr = ptrs.find { |ptr| ptr.value == srv_rr.name }

[... diff too long, it was truncated ...]

GitHub sha: 97fef916