DEV: mark vars as private and initialize with the controller (PR #10929)

Followup on #10888

GitHub

  _newPostsInStream: null,

and:

init() {
  this._super(...arguments);
  this.set("_newPostsInStream", []);

Or if you don’t need _newPostsInStream to be computed, you could just remove all of this and do:

init() {
  this._super(...arguments);
  this. _newPostsInStream = [];
}

If you want to know more about this: https://dockyard.com/blog/2015/09/18/ember-best-practices-avoid-leaking-state-into-factories

same a my other comment, if it’s not meant to be computed, you could just define it in init, although it’s not an array or object, so it’s fine like this.

K closing this… re-doing this with another fix.