DEV: Migrate deprecated badge icon names (PR #9760)

GitHub

@eviltrout I’m not sure whether it is OK that this relies on a JSON file outside migrations.

I think it’s OK to use a JSON file but putting it in lib implies it’s part of the app and it’s not clear it’s part of a migration.

I would make a copy of the file in the migrations directory, and maybe name it the same as the migration number? 20200513013022_fa4_renames.json

1 Like

That makes sense, thanks! I have made the change, but moved the PR back to draft for now, waiting to see whether we can do one and the same migration for group icons too (since it will use the same JSON file).

1 Like

Closing, superseded by DEV: Remove support for FA4 icon names by pmusaraj · Pull Request #9806 · discourse/discourse · GitHub