DEV: pass the current category to discovery-list-container-top on tag topic lists (PR #11690)

hnb-ku · January 12, 2021, 3:51pm

We pass the current category to the discovery-list-container-top on category topic lists here.

discourse/discourse/blob/59ef48c0b9d70a6639a545d1c96f3cc6f93ebf2c/app/assets/javascripts/discourse/app/templates/discovery.hbs#L29-L30


{{plugin-outlet name="discovery-list-container-top"
                args=(hash category=category listLoading=loading)}}

but we don’t pass it while on a category page and using a tag as a filter

github.com

discourse/discourse/blob/024d91410daab7e43629178544387e2746bbf86d/app/assets/javascripts/discourse/app/templates/tags/show.hbs#L42


        toggleInfo=(action "toggleInfo")
        }}
    </section>
  </div>
</div>
{{#if showInfo}}
  {{tag-info tag=tag list=list deleteAction=(action "deleteTag")}}
{{/if}}
{{plugin-outlet name="discovery-list-container-top"}}
<div class="container list-container">
  <div class="row">
    <div class="full-width">
      <div id="list-area">
        {{#unless loading}}
          {{#if list.topics}}
            {{#discovery-topics-list model=list refresh=(action "refresh")  as |discoveryTopicList|}}
              {{bulk-select-button selected=selected action=(action "refresh") category=category}}
              {{topic-list

This PR fixes that so that the current category is available there as well.

GitHub

eviltrout · January 12, 2021, 4:33pm

great find!

hnb-ku · January 13, 2021, 12:04pm

hnb-ku · January 13, 2021, 12:04pm