DEV: Refactor and test plugin addKeyboardShortcut (PR #9381)

Refactor plugin-api addKeyboardShortcut to point to KeyboardShortcuts.

  • Do not add shortcuts to the default object directly.
  • Create an addShortcut function in keyboard-shortcuts to add shortcuts safely and call to bindKey to be able to use opts.
  • Refactor controllers/bookmark.js to use new addShortcut func and emove unnecessary addBindings.
  • No longer export keyboard shortcut bindings, rename to DEFAULT_BINDINGS and remove export, these do not need to be accessed by anything else.


It looks extremely good to me :+1: awesome work!

I have nothing to say, but requested @markvanlan to have a look at this as he recently worked on this.