DEV: Refactor `dark-light-choose()` usage in SCSS

DEV: Refactor dark-light-choose() usage in SCSS

Covers most, but not all, cases.

diff --git a/app/assets/stylesheets/common/base/_topic-list.scss b/app/assets/stylesheets/common/base/_topic-list.scss
index a80e54c..ed3c311 100644
--- a/app/assets/stylesheets/common/base/_topic-list.scss
+++ b/app/assets/stylesheets/common/base/_topic-list.scss
@@ -302,7 +302,7 @@ ol.category-breadcrumb {
 }
 
 div.education {
-  color: dark-light-choose($primary-medium, $secondary-medium);
+  color: $primary-med-or-secondary-med;
   .badge-notification.new-posts {
     vertical-align: text-bottom;
   }
@@ -310,7 +310,7 @@ div.education {
 
 .list-cell {
   padding: 12px 5px;
-  color: dark-light-choose($primary-medium, $secondary-high);
+  color: $primary-med-or-secondary-high;
 }
 
 .table-heading {
diff --git a/app/assets/stylesheets/common/base/category-list.scss b/app/assets/stylesheets/common/base/category-list.scss
index 9387f2e..f8b72aa 100644
--- a/app/assets/stylesheets/common/base/category-list.scss
+++ b/app/assets/stylesheets/common/base/category-list.scss
@@ -123,7 +123,7 @@
     margin-bottom: 1em;
     text-align: center;
     font-size: $font-0;
-    color: dark-light-choose($primary-medium, $secondary-high);
+    color: $primary-med-or-secondary-high;
     position: relative;
     @include line-clamp(4);
 
diff --git a/app/assets/stylesheets/common/base/directory.scss b/app/assets/stylesheets/common/base/directory.scss
index b01248d..685c175 100644
--- a/app/assets/stylesheets/common/base/directory.scss
+++ b/app/assets/stylesheets/common/base/directory.scss
@@ -69,7 +69,7 @@
     }
   }
   .me {
-    background-color: dark-light-choose($highlight-low, $highlight-medium);
+    background-color: $highlight-low-or-medium;
     .username a,
     .name,
     .title,
diff --git a/app/assets/stylesheets/common/base/emoji.scss b/app/assets/stylesheets/common/base/emoji.scss
index 15269fe..313e030 100644
--- a/app/assets/stylesheets/common/base/emoji.scss
+++ b/app/assets/stylesheets/common/base/emoji.scss
@@ -108,10 +108,10 @@ sup img.emoji {
 .emoji-picker .section-header .clear-recent .fa {
   margin: 0;
   padding: 0;
-  color: dark-light-choose($header_primary-medium, $header_primary);
+  color: $primary-medium;
 
   &:hover {
-    color: $primary;
+    color: $primary-high;
   }
 }
 
@@ -237,7 +237,7 @@ sup img.emoji {
 }
 
 .emoji-picker .filter .d-icon-search {
-  color: dark-light-choose($header_primary-medium, $header_primary);
+  color: $primary-medium;
   font-size: $font-up-1;
   margin-left: 5px;
   margin-right: 5px;
@@ -279,7 +279,7 @@ sup img.emoji {
   top: 12px;
   border: 0;
   background: none;
-  color: dark-light-choose($header_primary-medium, $header_primary);
+  color: $primary-high;
   outline: none;
   display: none;
 
diff --git a/app/assets/stylesheets/common/base/group.scss b/app/assets/stylesheets/common/base/group.scss
index 2e87be8..547c82b 100644
--- a/app/assets/stylesheets/common/base/group.scss
+++ b/app/assets/stylesheets/common/base/group.scss
@@ -39,7 +39,7 @@
 
   .group-info-full-name {
     font-size: $font-up-2;
-    color: dark-light-choose($primary-high, $secondary-low);
+    color: $primary-high-or-secondary-low;
   }
 
   span {
diff --git a/app/assets/stylesheets/common/base/menu-panel.scss b/app/assets/stylesheets/common/base/menu-panel.scss
index 357bade..25412b0 100644
--- a/app/assets/stylesheets/common/base/menu-panel.scss
+++ b/app/assets/stylesheets/common/base/menu-panel.scss
@@ -85,7 +85,7 @@
     .new {
       font-size: $font-down-1;
       margin-left: 0.5em;
-      color: dark-light-choose($primary-medium, $secondary-medium);
+      color: $primary-med-or-secondary-med;
     }
   }
 
@@ -109,7 +109,7 @@
       }
     }
     .badge-notification {
-      color: dark-light-choose($primary-medium, $secondary-medium);
+      color: $primary-med-or-secondary-med;
       background-color: transparent;
       display: inline;
       padding: 0;
@@ -136,7 +136,7 @@
 
   // note these topic counts only appear for anons in the category hamburger drop down
   b.topics-count {
-    color: dark-light-choose($primary-medium, $secondary-medium);
+    color: $primary-med-or-secondary-med;
     font-weight: normal;
     font-size: $font-down-1;
   }
@@ -251,7 +251,7 @@
       justify-content: center;
       align-items: center;
       min-height: 30px;
-      color: dark-light-choose($primary-medium, $secondary-high);
+      color: $primary-med-or-secondary-high;
       background: $blend-primary-secondary-5;
       &:hover {
         color: $primary;
@@ -320,7 +320,7 @@ div.menu-links-header {
       }
 
       a.active {
-        border: 1px solid dark-light-choose($primary-low, $secondary-medium);
+        border: 1px solid $primary-low;
         border-bottom: 1px solid $secondary;
         position: relative;
 
@@ -373,7 +373,7 @@ div.menu-links-header {
   }
   .fa,
   a {
-    color: dark-light-choose($primary-medium, $secondary-medium);
+    color: $primary-med-or-secondary-med;
   }
 
   .d-icon-user {
diff --git a/app/assets/stylesheets/common/base/onebox.scss b/app/assets/stylesheets/common/base/onebox.scss
index 359ad30..341b945 100644
--- a/app/assets/stylesheets/common/base/onebox.scss
+++ b/app/assets/stylesheets/common/base/onebox.scss
@@ -103,7 +103,7 @@ aside.onebox {
   header {
     margin-bottom: 8px;
     a[href] {
-      color: dark-light-choose($primary-medium, $secondary-medium);
+      color: $primary-med-or-secondary-med;
       text-decoration: none;
     }
   }
@@ -600,7 +600,7 @@ aside.onebox.stackexchange .onebox-body {
 }
 
 .onebox-metadata {
-  color: dark-light-choose($primary-medium, $secondary-medium);
+  color: $primary-med-or-secondary-med;
 }
 
 .onebox.xkcd .onebox-body {
@@ -630,7 +630,7 @@ aside.onebox.stackexchange .onebox-body {
 .onebox.whitelistedgeneric {
   .label1,
   .label2 {
-    color: dark-light-choose($primary-medium, $secondary-medium);
+    color: $primary-med-or-secondary-med;
   }
   .label1 {
     float: left;
@@ -660,7 +660,7 @@ aside.onebox.stackexchange .onebox-body {
 
 .onebox.instagram {
   div.instagram-description {
-    color: dark-light-choose($primary-medium, $secondary-medium);
+    color: $primary-med-or-secondary-med;
     padding-top: 10px;
   }
 }
@@ -670,7 +670,7 @@ aside.onebox.stackexchange .onebox-body {
     position: relative;
   }
   div.description {
-    color: dark-light-choose($primary-medium, $secondary-medium);
+    color: $primary-med-or-secondary-med;
   }
 }
 
@@ -683,7 +683,7 @@ aside.onebox.stackexchange .onebox-body {
 .onebox.twitterstatus {
   .like,
   .retweet {
-    color: dark-light-choose($primary-medium, $secondary-medium);
+    color: $primary-med-or-secondary-med;
     padding-left: 10px;
     svg {
       fill: currentColor;
diff --git a/app/assets/stylesheets/common/base/reviewables.scss b/app/assets/stylesheets/common/base/reviewables.scss
index 8c2bc4f..569cfc5 100644
--- a/app/assets/stylesheets/common/base/reviewables.scss
+++ b/app/assets/stylesheets/common/base/reviewables.scss
@@ -234,7 +234,7 @@
   }
 
   .reviewable-meta-data {
-    color: dark-light-choose($primary-medium, $secondary-medium);
+    color: $primary-med-or-secondary-med;
     display: flex;
     width: 100%;
     margin-bottom: 0.5em;
@@ -250,7 +250,7 @@
       margin-left: 1em;
       margin-right: auto;
       a {
-        color: dark-light-choose($primary-medium, $secondary-medium);
+        color: $primary-med-or-secondary-med;
       }
     }
     .score {
diff --git a/app/assets/stylesheets/common/base/search-menu.scss b/app/assets/stylesheets/common/base/search-menu.scss
index 530a133..354fb89 100644
--- a/app/assets/stylesheets/common/base/search-menu.scss
+++ b/app/assets/stylesheets/common/base/search-menu.scss
@@ -213,12 +213,12 @@
             }
 
             .username {
-              color: dark-light-choose($primary-high, $secondary-low);
+              color: $primary-high-or-secondary-low;
               font-size: $font-down-1;
             }
 
             .name {

[... diff too long, it was truncated ...]

GitHub sha: 3116591d