DEV: Remove migration tests that have served their purpose.

DEV: Remove migration tests that have served their purpose.

diff --git a/spec/db/migrate/add_upload_foreign_keys_to_user_profiles_spec.rb b/spec/db/migrate/add_upload_foreign_keys_to_user_profiles_spec.rb
deleted file mode 100644
index 78417a7..0000000
--- a/spec/db/migrate/add_upload_foreign_keys_to_user_profiles_spec.rb
+++ /dev/null
@@ -1,79 +0,0 @@
-require 'rails_helper'
-require 'migration/column_dropper'
-require_relative '../../../db/migrate/20190426011148_add_upload_foreign_keys_to_user_profiles'
-
-RSpec.describe AddUploadForeignKeysToUserProfiles do
-  before do
-    %i{card_background profile_background}.each do |column|
-      # In the future when the column is dropped
-      # DB.exec("ALTER TABLE user_profiles ADD COLUMN #{column} VARCHAR;")
-      Migration::ColumnDropper.drop_readonly(:user_profiles, column)
-    end
-
-    %i{card_background_upload_id profile_background_upload_id}.each do |column|
-      DB.exec("ALTER TABLE user_profiles DROP COLUMN IF EXISTS #{column}")
-    end
-  end
-
-  def select_column_from_user_profiles(column, user_id)
-    DB.query_single(<<~SQL).first
-    SELECT #{column}
-    FROM user_profiles
-    WHERE user_id = #{user_id}
-    SQL
-  end
-
-  it "should migrate the data properly" do
-    upload = Fabricate(:upload)
-    upload2 = Fabricate(:upload)
-    user = Fabricate(:user)
-    user2 = Fabricate(:user)
-    user3 = Fabricate(:user)
-
-    DB.exec(<<~SQL)
-    UPDATE user_profiles
-    SET card_background = '#{upload.url}', profile_background = '#{upload.url}'
-    WHERE user_profiles.user_id = #{user.id}
-    SQL
-
-    DB.exec(<<~SQL)
-    UPDATE user_profiles
-    SET card_background = '#{upload.url}', profile_background = '#{upload2.url}'
-    WHERE user_profiles.user_id = #{user2.id}
-    SQL
-
-    DB.exec(<<~SQL)
-    UPDATE user_profiles
-    SET card_background = '#{upload.url}'
-    WHERE user_profiles.user_id = #{user3.id}
-    SQL
-
-    silence_stdout { described_class.new.up }
-
-    %i{card_background profile_background}.each do |column|
-      expect(select_column_from_user_profiles(column, user.id))
-        .to eq(upload.url)
-    end
-
-    %i{card_background_upload_id profile_background_upload_id}.each do |column|
-      expect(select_column_from_user_profiles(column, user.id))
-        .to eq(upload.id)
-    end
-
-    expect(select_column_from_user_profiles(
-      :card_background_upload_id, user2.id
-    )).to eq(upload.id)
-
-    expect(select_column_from_user_profiles(
-      :profile_background_upload_id, user2.id
-    )).to eq(upload2.id)
-
-    expect(select_column_from_user_profiles(
-      :card_background_upload_id, user3.id
-    )).to eq(upload.id)
-
-    expect(select_column_from_user_profiles(
-      :profile_background_upload_id, user3.id
-    )).to eq(nil)
-  end
-end
diff --git a/spec/db/migrate/add_uploads_to_categories_spec.rb b/spec/db/migrate/add_uploads_to_categories_spec.rb
deleted file mode 100644
index b890543..0000000
--- a/spec/db/migrate/add_uploads_to_categories_spec.rb
+++ /dev/null
@@ -1,56 +0,0 @@
-require 'rails_helper'
-require 'migration/column_dropper'
-require_relative '../../../db/migrate/20161202034856_add_uploads_to_categories'
-
-RSpec.describe AddUploadsToCategories do
-  before do
-    %i{logo_url background_url}.each do |column|
-      DB.exec("ALTER TABLE categories ADD COLUMN #{column} VARCHAR;")
-    end
-
-    %i{uploaded_logo_id uploaded_background_id}.each do |column|
-      DB.exec("ALTER TABLE categories DROP COLUMN IF EXISTS #{column}")
-    end
-  end
-
-  def select_column_from_categories(column, category_id)
-    DB.query_single(<<~SQL).first
-    SELECT #{column}
-    FROM categories
-    WHERE id = #{category_id}
-    SQL
-  end
-
-  it "should migrate the data properly" do
-    upload1 = Fabricate(:upload)
-    upload2 = Fabricate(:upload)
-    category1 = Fabricate(:category)
-    category2 = Fabricate(:category)
-
-    DB.exec(<<~SQL)
-    UPDATE categories
-    SET logo_url = '#{upload1.url}', background_url = '#{upload2.url}'
-    WHERE categories.id = #{category1.id}
-    SQL
-
-    DB.exec(<<~SQL)
-    UPDATE categories
-    SET logo_url = '#{upload2.url}', background_url = '#{upload1.url}'
-    WHERE categories.id = #{category2.id}
-    SQL
-
-    silence_stdout { described_class.new.up }
-
-    expect(select_column_from_categories(:uploaded_logo_id, category1.id))
-      .to eq(upload1.id)
-
-    expect(select_column_from_categories(:uploaded_background_id, category1.id))
-      .to eq(upload2.id)
-
-    expect(select_column_from_categories(:uploaded_logo_id, category2.id))
-      .to eq(upload2.id)
-
-    expect(select_column_from_categories(:uploaded_background_id, category2.id))
-      .to eq(upload1.id)
-  end
-end

GitHub sha: 1815409a

1 Like