DEV: Remove old deprecations (PR #14906)

GitHub

This pull request introduces 1 alert when merging d1f256e064b2e1741abc348f00252413fa52f377 into 79f49dfb7ae41221fbdb004a50ef493c8ed34164 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

I suspect this is going to break a lot of sites. In particular the {{themeSetting.blah}}, Discourse.Site and Discourse.User changes. We should proceed with extreme caution if we want to finally remove these.

As David I think we should at least wait after the bump.

I didn’t find any {{themeSetting.blah}} in all-the repos, and the Discourse global doesn’t seem to be used in any official plugins anymore, but I agree we should wait with the merge after the bump. In the meantime I’ll see if there are any (maintained) 3rd-party plugins that could use a PR.