DEV: Remove rb-inotify gem from Gemfile

DEV: Remove rb-inotify gem from Gemfile

We are no longer directly referencing the rb-inotify gem directly in code. This was just a spec level dependency anyways.

Using git log -S "Inotify" resulted in these two commits as usages of Inotify:

  • b56b11d96aafa5cd9e2f004ae631348fba4574ae
  • 9cf03b352cb2bff7c9a7a56211d56a921ed13664

both from 2013, but we no longer are using inotify in

https://github.com/discourse/discourse/blob/master/lib/tasks/autospec.rake

which appears to be the only file that was using it.

Based on this info we can safely remove rb-inotify from the Gemfile.

Just as a side note we still do have a couple of gems that do have rb-inotify as a dependency: listen, and lru_redux.

diff --git a/Gemfile b/Gemfile
index 68d0342..8baf3db 100644
--- a/Gemfile
+++ b/Gemfile
@@ -159,10 +159,6 @@ group :test, :development do
 
   gem 'rb-fsevent', require: RUBY_PLATFORM =~ /darwin/i ? 'rb-fsevent' : false
 
-  # TODO determine if we can update this to 0.10, API changes happened
-  # we would like to upgrade it if possible
-  gem 'rb-inotify', '~> 0.9', require: RUBY_PLATFORM =~ /linux/i ? 'rb-inotify' : false
-
   gem 'rspec-rails'
 
   gem 'shoulda-matchers', require: false
diff --git a/Gemfile.lock b/Gemfile.lock
index 75b3f76..9c176ba 100644
--- a/Gemfile.lock
+++ b/Gemfile.lock
@@ -521,7 +521,6 @@ DEPENDENCIES
   railties (= 6.0.3.2)
   rake
   rb-fsevent
-  rb-inotify (~> 0.9)
   rbtrace
   rchardet
   redis

GitHub sha: d79f50a3

1 Like

This commit appears in #10574 which was merged by tgxworld.