DEV: Remove SiteSetting.s3_force_path_style (PR #7210)

  • s3_force_path_style was added as a Minio specific url scheme but it has never been well supported in our code base.
  • Our new migrate_to_s3 rake task does not work reliably with path style urls too
  • Minio has also added support for virtual style requests i.e the same scheme as AWS S3/DO Spaces so we can rely on that instead of using path style requests.

GitHub

You’ve signed the CLA, rishabhnambiar. Thank you! This pull request is ready for review.

You’ll need to write a migration to drop the record from the site_settings table as well :slight_smile:

This pull request has been mentioned on Discourse Meta. There might be relevant details there:

https://meta.discourse.org/t/backup-is-failing-due-to-bad-https/113041/16