DEV: Remove staff bypass on fix missing

DEV: Remove staff bypass on fix missing

After thinking about it, I worry that this will potentially leave a site setting set when people hit ctrl-c … feels a tiny bit risky, so leaving it out.

diff --git a/lib/tasks/uploads.rake b/lib/tasks/uploads.rake
index 013f9a9..89e3892 100644
--- a/lib/tasks/uploads.rake
+++ b/lib/tasks/uploads.rake
@@ -1181,20 +1181,12 @@ def fix_missing_s3
   puts
 end
 
-def allow_all_uploads
-  old_staff_extension = SiteSetting.authorized_extensions_for_staff
-  SiteSetting.authorized_extensions_for_staff = "*"
-  yield
-ensure
-  SiteSetting.authorized_extensions_for_staff = old_staff_extension
-end
-
 task "uploads:fix_missing_s3" => :environment do
   if RailsMultisite::ConnectionManagement.current_db != "default"
-    allow_all_uploads { fix_missing_s3 }
+    fix_missing_s3
   else
     RailsMultisite::ConnectionManagement.each_connection do
-      allow_all_uploads { fix_missing_s3 }
+      fix_missing_s3
     end
   end
 end

GitHub sha: 80e17f5f

1 Like