DEV: Rename i18n keys because they're not i18n pluralization keys

DEV: Rename i18n keys because they’re not i18n pluralization keys

diff --git a/assets/javascripts/discourse/widgets/code-review-commit-approved-notification-item.js.es6 b/assets/javascripts/discourse/widgets/code-review-commit-approved-notification-item.js.es6
index edbc380..1e8b882 100644
--- a/assets/javascripts/discourse/widgets/code-review-commit-approved-notification-item.js.es6
+++ b/assets/javascripts/discourse/widgets/code-review-commit-approved-notification-item.js.es6
@@ -18,11 +18,11 @@ createWidgetFrom(
       const numApprovedCommits = data.num_approved_commits;
 
       if (numApprovedCommits === 1) {
-        return I18n.t("notifications.code_review.commit_approved.one", {
+        return I18n.t("notifications.code_review.commit_approved.single", {
           topicTitle: this.attrs.fancy_title
         });
       } else {
-        return I18n.t("notifications.code_review.commit_approved.many", {
+        return I18n.t("notifications.code_review.commit_approved.multiple", {
           numApprovedCommits
         });
       }
diff --git a/config/locales/client.en.yml b/config/locales/client.en.yml
index 02047b9..af7a501 100644
--- a/config/locales/client.en.yml
+++ b/config/locales/client.en.yml
@@ -7,8 +7,8 @@ en:
     notifications:
       code_review:
         commit_approved:
-          one: "\"{{topicTitle}}\" approved"
-          many: "{{numApprovedCommits}} commits were approved"
+          single: "\"{{topicTitle}}\" approved"
+          multiple: "{{numApprovedCommits}} commits were approved"
           title: "commit approved"
     code_review:
       approve:

GitHub sha: 2a6101b4

3 Likes