DEV: rename refresh action to avoid regressions in the future (PR #14721)

This is a follow-up to FIX: infinite recursion when calling a refresh() action on routes by AndrewPrigorshnev · Pull Request #14624 · discourse/discourse · GitHub. That PR fixes bugs with stack overflow. This PR doesn’t fix any bug, everything works fine here, but a route action named refresh is a bit dangerous. It works now when we use the old syntax:

  actions: {
    refresh() {
      this.refresh(); // this calls the `refresh` method of Route
    },
  },

But if someone migrates this to the new syntax, they can introduce the same bug with stack overflow:

  @action
  refresh() {
    this.refresh(); // this calls the `refresh` action itself instead of calling the `refresh` method of Route
  },

I’ve renamed the action and migrated it to the new syntax to avoid problems in the future. And it was the last action named refresh on routes in Core.

GitHub