DEV: Replace `equal()` with `strictEqual()` (#14827)

DEV: Replace equal() with strictEqual() (#14827)

diff --git a/app/assets/javascripts/discourse/tests/acceptance/account-created-test.js b/app/assets/javascripts/discourse/tests/acceptance/account-created-test.js
index 0eac23b..f2cd00f 100644
--- a/app/assets/javascripts/discourse/tests/acceptance/account-created-test.js
+++ b/app/assets/javascripts/discourse/tests/acceptance/account-created-test.js
@@ -15,7 +15,7 @@ acceptance("Account Created", function () {
     await visit("/u/account-created");
 
     assert.ok(exists(".account-created"));
-    assert.equal(
+    assert.strictEqual(
       queryAll(".account-created .ac-message").text().trim(),
       "Hello World",
       "it displays the message"
@@ -34,7 +34,7 @@ acceptance("Account Created", function () {
     await visit("/u/account-created");
 
     assert.ok(exists(".account-created"));
-    assert.equal(
+    assert.strictEqual(
       queryAll(".account-created .ac-message").text().trim(),
       "Hello World",
       "it displays the message"
@@ -42,9 +42,9 @@ acceptance("Account Created", function () {
 
     await click(".activation-controls .resend");
 
-    assert.equal(currentRouteName(), "account-created.resent");
+    assert.strictEqual(currentRouteName(), "account-created.resent");
     const email = queryAll(".account-created .ac-message b").text();
-    assert.equal(email, "eviltrout@example.com");
+    assert.strictEqual(email, "eviltrout@example.com");
   });
 
   test("account created - update email - cancel", async function (assert) {
@@ -59,12 +59,12 @@ acceptance("Account Created", function () {
 
     await click(".activation-controls .edit-email");
 
-    assert.equal(currentRouteName(), "account-created.edit-email");
+    assert.strictEqual(currentRouteName(), "account-created.edit-email");
     assert.ok(exists(".activation-controls .btn-primary:disabled"));
 
     await click(".activation-controls .edit-cancel");
 
-    assert.equal(currentRouteName(), "account-created.index");
+    assert.strictEqual(currentRouteName(), "account-created.index");
   });
 
   test("account created - update email - submit", async function (assert) {
@@ -87,8 +87,8 @@ acceptance("Account Created", function () {
 
     await click(".activation-controls .btn-primary");
 
-    assert.equal(currentRouteName(), "account-created.resent");
+    assert.strictEqual(currentRouteName(), "account-created.resent");
     const email = queryAll(".account-created .ac-message b").text();
-    assert.equal(email, "newemail@example.com");
+    assert.strictEqual(email, "newemail@example.com");
   });
 });
diff --git a/app/assets/javascripts/discourse/tests/acceptance/admin-badges-award-test.js b/app/assets/javascripts/discourse/tests/acceptance/admin-badges-award-test.js
index c2c6e66..8f9ad67 100644
--- a/app/assets/javascripts/discourse/tests/acceptance/admin-badges-award-test.js
+++ b/app/assets/javascripts/discourse/tests/acceptance/admin-badges-award-test.js
@@ -14,7 +14,7 @@ acceptance("Admin - Badges - Mass Award", function (needs) {
     await click(
       '.admin-badge-list-item span[data-badge-name="Both image and icon"]'
     );
-    assert.equal(
+    assert.strictEqual(
       query("label.grant-existing-holders").textContent.trim(),
       I18n.t("admin.badges.mass_award.grant_existing_holders"),
       "checkbox for granting existing holders is displayed"
diff --git a/app/assets/javascripts/discourse/tests/acceptance/admin-badges-show-test.js b/app/assets/javascripts/discourse/tests/acceptance/admin-badges-show-test.js
index e0a52b1..531342e 100644
--- a/app/assets/javascripts/discourse/tests/acceptance/admin-badges-show-test.js
+++ b/app/assets/javascripts/discourse/tests/acceptance/admin-badges-show-test.js
@@ -51,7 +51,7 @@ acceptance("Admin - Badges - Show", function (needs) {
     );
     assert.ok(exists(".icon-picker"), "icon picker is visible");
     assert.ok(!exists(".image-uploader"), "image uploader is not visible");
-    assert.equal(query(".icon-picker").textContent.trim(), "fa-rocket");
+    assert.strictEqual(query(".icon-picker").textContent.trim(), "fa-rocket");
   });
 
   test("existing badge that has an image URL", async function (assert) {
@@ -92,6 +92,6 @@ acceptance("Admin - Badges - Show", function (needs) {
     await click("input#badge-icon");
     assert.ok(exists(".icon-picker"), "icon picker is becomes visible");
     assert.ok(!exists(".image-uploader"), "image uploader becomes hidden");
-    assert.equal(query(".icon-picker").textContent.trim(), "fa-rocket");
+    assert.strictEqual(query(".icon-picker").textContent.trim(), "fa-rocket");
   });
 });
diff --git a/app/assets/javascripts/discourse/tests/acceptance/admin-emails-test.js b/app/assets/javascripts/discourse/tests/acceptance/admin-emails-test.js
index 0b2342b..12af83c 100644
--- a/app/assets/javascripts/discourse/tests/acceptance/admin-emails-test.js
+++ b/app/assets/javascripts/discourse/tests/acceptance/admin-emails-test.js
@@ -32,8 +32,8 @@ acceptance("Admin - Emails", function (needs) {
     await fillIn("textarea.email-body", EMAIL.trim());
     await click(".email-advanced-test button");
 
-    assert.equal(queryAll(".text pre").text(), "Hello, this is a test!");
-    assert.equal(
+    assert.strictEqual(queryAll(".text pre").text(), "Hello, this is a test!");
+    assert.strictEqual(
       queryAll(".elided pre").text(),
       "---\n\nThis part should be elided."
     );
diff --git a/app/assets/javascripts/discourse/tests/acceptance/admin-install-theme-modal-test.js b/app/assets/javascripts/discourse/tests/acceptance/admin-install-theme-modal-test.js
index 8c85c6e..27eaf15 100644
--- a/app/assets/javascripts/discourse/tests/acceptance/admin-install-theme-modal-test.js
+++ b/app/assets/javascripts/discourse/tests/acceptance/admin-install-theme-modal-test.js
@@ -20,8 +20,8 @@ acceptance("Admin - Themes - Install modal", function (needs) {
     await click(".install-theme-content .inputs .advanced-repo");
     await fillIn(branchInput, "tests-passed");
     await click(privateRepoCheckbox);
-    assert.equal(query(urlInput).value, themeUrl, "url input is filled");
-    assert.equal(
+    assert.strictEqual(query(urlInput).value, themeUrl, "url input is filled");
+    assert.strictEqual(
       query(branchInput).value,
       "tests-passed",
       "branch input is filled"
@@ -36,8 +36,8 @@ acceptance("Admin - Themes - Install modal", function (needs) {
 
     await click(".create-actions .btn-primary");
     await click("#remote");
-    assert.equal(query(urlInput).value, "", "url input is reset");
-    assert.equal(query(branchInput).value, "", "branch input is reset");
+    assert.strictEqual(query(urlInput).value, "", "url input is reset");
+    assert.strictEqual(query(branchInput).value, "", "branch input is reset");
     assert.ok(
       !query(privateRepoCheckbox).checked,
       "private repo checkbox unchecked"
@@ -60,7 +60,7 @@ acceptance("Admin - Themes - Install modal", function (needs) {
     await fillIn(urlInput, themeUrl);
     await click(".install-theme-content .inputs .advanced-repo");
     await click(privateRepoCheckbox);
-    assert.equal(query(urlInput).value, themeUrl, "url input is filled");
+    assert.strictEqual(query(urlInput).value, themeUrl, "url input is filled");
     assert.ok(
       query(privateRepoCheckbox).checked,
       "private repo checkbox is checked"
@@ -84,7 +84,7 @@ acceptance("Admin - Themes - Install modal", function (needs) {
   test("modal can be auto-opened with the right query params", async function (assert) {
     await visit("/admin/customize/themes?repoUrl=testUrl&repoName=testName");
     assert.ok(query(".admin-install-theme-modal"), "modal is visible");
-    assert.equal(
+    assert.strictEqual(
       query(".install-theme code").textContent.trim(),
       "testUrl",
       "repo url is visible"
@@ -101,7 +101,7 @@ acceptance("Admin - Themes - Install modal", function (needs) {
       ),
       "no install button is shown for installed themes"
     );
-    assert.equal(

[... diff too long, it was truncated ...]

GitHub sha: d162229758320648de2c2e59b02a0c1924361fed

This commit appears in #14827 which was approved by jjaffeux. It was merged by CvX.