DEV: Resolve some template linting issues (#123)

DEV: Resolve some template linting issues (#123)

Some larger issues still remain, but this is a good first step

diff --git a/Gemfile.lock b/Gemfile.lock
index 259af31..9205aec 100644
--- a/Gemfile.lock
+++ b/Gemfile.lock
@@ -31,4 +31,4 @@ DEPENDENCIES
   rubocop-discourse
 
 BUNDLED WITH
-   2.2.7
+   2.2.15
diff --git a/assets/javascripts/discourse/templates/admin/plugins-explorer.hbs b/assets/javascripts/discourse/templates/admin/plugins-explorer.hbs
index 916a46a..b8a06e3 100644
--- a/assets/javascripts/discourse/templates/admin/plugins-explorer.hbs
+++ b/assets/javascripts/discourse/templates/admin/plugins-explorer.hbs
@@ -30,7 +30,7 @@
           {{#if selectedItem}}
             {{#if editing}}
               <div class="name">
-                  {{d-button action=(action "goHome") icon="chevron-left" class="previous"}}
+                {{d-button action=(action "goHome") icon="chevron-left" class="previous"}}
                 <div class="name-text-field">
                   {{text-field value=selectedItem.name}}
                 </div>
@@ -42,9 +42,10 @@
             {{else}}
               <div class="name">
                 {{d-button action=(action "goHome") icon="chevron-left" class="previous"}}
-                <h1>{{selectedItem.name}}
+                <h1>
+                  {{selectedItem.name}}
                   {{#unless editDisabled}}
-                    <a {{action "editName" class="edit-query-name"}}>{{d-icon "pencil-alt"}}</a>
+                    <a href {{action "editName" class="edit-query-name"}}>{{d-icon "pencil-alt"}}</a>
                   {{/unless}}
                 </h1>
               </div>
@@ -212,32 +213,32 @@
                       <medium>{{query.username}}</medium>
                     </a>
                   {{/if}}
-                </td>
-                <td class="query-group-names">
-                  {{#each query.group_names as |group|}}
-                    {{share-report group=group query=query}}
-                  {{/each}}
-                </td>
-                <td class="query-created-at">
-                  {{#if query.last_run_at}}
-                    <medium>
-                      {{bound-date query.last_run_at}}
-                    </medium>
-                  {{else if query.created_at}}
-                    <medium>
-                      {{bound-date query.created_at}}
-                    </medium>
-                  {{/if}}
-                </td>
-              </tr>
-            {{else}}
-              <br>
-              <em class="no-search-results"> {{i18n "explorer.no_search_results"}}</em>
-            {{/each}}
-          </tbody>
-        </table>
-      </div>
-    {{/if}}
+                  </td>
+                  <td class="query-group-names">
+                    {{#each query.group_names as |group|}}
+                      {{share-report group=group query=query}}
+                    {{/each}}
+                  </td>
+                  <td class="query-created-at">
+                    {{#if query.last_run_at}}
+                      <medium>
+                        {{bound-date query.last_run_at}}
+                      </medium>
+                    {{else if query.created_at}}
+                      <medium>
+                        {{bound-date query.created_at}}
+                      </medium>
+                    {{/if}}
+                  </td>
+                </tr>
+              {{else}}
+                <br>
+                <em class="no-search-results"> {{i18n "explorer.no_search_results"}}</em>
+              {{/each}}
+            </tbody>
+          </table>
+        </div>
+      {{/if}}
 
       <div class="explorer-pad-bottom"></div>
 
diff --git a/assets/javascripts/discourse/templates/components/explorer-schema-enuminfo.hbs b/assets/javascripts/discourse/templates/components/explorer-schema-enuminfo.hbs
index b5e98b3..0fbba51 100644
--- a/assets/javascripts/discourse/templates/components/explorer-schema-enuminfo.hbs
+++ b/assets/javascripts/discourse/templates/components/explorer-schema-enuminfo.hbs
@@ -1,5 +1,5 @@
 {{#each enuminfo as |enum|}}
-  <li value="{{enum.value}}">
+  <li value={{enum.value}}>
     {{enum.name}}
   </li>
 {{/each}}
diff --git a/assets/javascripts/discourse/templates/components/explorer-schema-onetable.hbs b/assets/javascripts/discourse/templates/components/explorer-schema-onetable.hbs
index c7dddc2..6af967c 100644
--- a/assets/javascripts/discourse/templates/components/explorer-schema-onetable.hbs
+++ b/assets/javascripts/discourse/templates/components/explorer-schema-onetable.hbs
@@ -9,36 +9,36 @@
 <div class="schema-table-cols">
   {{#if open}}
     <dl>
-    {{#each table.columns as |col|}}
-      <div>
-      <dt class="{{if col.sensitive "sensitive"}}" title="{{if col.sensitive (i18n "explorer.schema.sensitive")}}">
-        {{#if col.sensitive}}
-          {{d-icon "exclamation-triangle"}}
-        {{/if}}
-        {{col.column_name}}
-      </dt>
-      <dd>
-        {{col.data_type}}
-        {{#if col.havetypeinfo}}
-          <br>
-          {{#if col.havepopup}}
-            <div class="popup-info">
-              {{d-icon "info"}}
-              <div class="popup">
-                {{col.column_desc}}
-                {{#if col.enum}}
-                  {{explorer-schema-enuminfo col=col}}
-                {{/if}}
-              </div>
-            </div>
-          {{/if}}
-          <span class="schema-typenotes">
-            {{col.notes}}
-          </span>
-        {{/if}}
-      </dd>
-      </div>
-    {{/each}}
+      {{#each table.columns as |col|}}
+        <div>
+          <dt class={{if col.sensitive "sensitive"}} title={{if col.sensitive (i18n "explorer.schema.sensitive")}}>
+            {{#if col.sensitive}}
+              {{d-icon "exclamation-triangle"}}
+            {{/if}}
+            {{col.column_name}}
+          </dt>
+          <dd>
+            {{col.data_type}}
+            {{#if col.havetypeinfo}}
+              <br>
+              {{#if col.havepopup}}
+                <div class="popup-info">
+                  {{d-icon "info"}}
+                  <div class="popup">
+                    {{col.column_desc}}
+                    {{#if col.enum}}
+                      {{explorer-schema-enuminfo col=col}}
+                    {{/if}}
+                  </div>
+                </div>
+              {{/if}}
+              <span class="schema-typenotes">
+                {{col.notes}}
+              </span>
+            {{/if}}
+          </dd>
+        </div>
+      {{/each}}
     </dl>
   {{/if}}
 </div>
diff --git a/assets/javascripts/discourse/templates/components/explorer-schema.hbs b/assets/javascripts/discourse/templates/components/explorer-schema.hbs
index 5c8c457..75c08db 100644
--- a/assets/javascripts/discourse/templates/components/explorer-schema.hbs
+++ b/assets/javascripts/discourse/templates/components/explorer-schema.hbs
@@ -1,4 +1,4 @@
-<div class="{{if hideSchema "hidden"}}">
+<div class={{if hideSchema "hidden"}}>
   {{text-field value=filter placeholderKey="explorer.schema.filter"}}
   {{d-button action=(action "collapseSchema") icon="chevron-right" class="no-text"}}
   {{conditional-loading-spinner condition=loading}}
diff --git a/assets/javascripts/discourse/templates/components/json-file-uploader.hbs b/assets/javascripts/discourse/templates/components/json-file-uploader.hbs
index 315adc3..f3baef5 100644
--- a/assets/javascripts/discourse/templates/components/json-file-uploader.hbs
+++ b/assets/javascripts/discourse/templates/components/json-file-uploader.hbs
@@ -1,7 +1,7 @@
 <div class="jsfu-shade-container">
   <div class="jsfu-file">
     <input id="js-file-input" type="file" style="display:none;" accept={{accept}}>
-    {{d-button class="fileSelect" action=(action "selectFile") class="" icon="upload" label="upload_selector.select_file"}}
+    {{d-button class="fileSelect" action=(action "selectFile") icon="upload" label="upload_selector.select_file"}}
     {{conditional-loading-spinner condition=loading size="small"}}
   </div>
   <div class="jsfu-separator">

[... diff too long, it was truncated ...]

GitHub sha: 4354e1b766a07ab8cf259f53c3518a9ebd97b90b

This commit appears in #123 which was approved by CvX. It was merged by davidtaylorhq.