DEV: small refactor of the category_moderators method (PR #12550)

[ZogStriP]

Used index_by(&:id) instead of map { |u| [u.id, u] }.to_h thanks to @cvx’s recommendation.

Also renamed the moderators variable to not clash with method of the same name.

GitHub

[CvX]

app/models/about.rb

@@ -103,10 +103,10 @@ def category_moderators
       ORDER BY c.position
     SQL
 
-    moderators = User.where(id: results.map(&:user_ids).flatten.uniq).map { |u| [u.id, u] }.to_h
+    mods = User.where(id: results.map(&:user_ids).flatten.uniq).index_by(&:id)
 
     results.map do |row|
-      CategoryMods.new(row.category_id, row.user_ids.map { |id| moderators[id] })
+      CategoryMods.new(row.category_id, row.user_ids.map { |id| mods[id] })

How about more code golf?

      CategoryMods.new(row.category_id, mods.values_at(row.user_ids))

[CvX]

Hm, that didn’t work as expected

[CvX]

app/models/about.rb

@@ -103,10 +103,10 @@ def category_moderators
       ORDER BY c.position
     SQL
 
-    moderators = User.where(id: results.map(&:user_ids).flatten.uniq).map { |u| [u.id, u] }.to_h
+    mods = User.where(id: results.map(&:user_ids).flatten.uniq).index_by(&:id)
 
     results.map do |row|
-      CategoryMods.new(row.category_id, row.user_ids.map { |id| moderators[id] })
+      CategoryMods.new(row.category_id, mods.values_at(row.user_ids))

My bad, values_at accepts varargs, not an array:

      CategoryMods.new(row.category_id, mods.values_at(*row.user_ids))