DEV: support --fail-fast in bin/turbo_rspec (PR #8170)

GitHub

1 Like

You’ve signed the CLA, markvanlan. Thank you! This pull request is ready for review.

The title of this pull request changed from “FEATURE: support --fast-fail in bin/turbo_rspec” to "DEV: support --fast-fail in bin/turbo_rspec

The title of this pull request changed from “DEV: support --fast-fail in bin/turbo_rspec” to "DEV: support --fail-fast in bin/turbo_rspec

With such a short method, this is a borderline nitpick, but I like to see more of a separation between methods that do things and methods that report on the state of things. As a caller, I don’t expect a method called fail_fast_met to start killing threads.

Other than that, I’d be happy to see this merged.

1 Like