DEV: suppress assets logs from qunit tests (PR #13871)

This is just adding noise in logs and probably making the tests slightly slower.

GitHub

That’s a simple change, but I tried more things than am willing to admit before getting to this :sweat_smile:

You will still get flooded by 404s when running tests in a non-headless browser. And let’s hope no code/test depends on img.onload since that won’t trigger with images disabled. :wink:

You will still get flooded by 404s when running tests in a non-headless browser. And let’s hope no code/test depends on img.onload since that won’t trigger with images disabled. :wink:

yes but this is mostly annoying on CI and we don’t have any test failing from this so far

You will still get flooded by 404s when running tests in a non-headless browser. And let’s hope no code/test depends on img.onload since that won’t trigger with images disabled. :wink:

Well of course… one plugin does…

Test Errors

Test Failed: getMetadata - image file Assertion Failed: Test took longer than 10000ms; test timed out. at eval (lib/uploads-test:10:19) at obj (discourse-loader:366:31) at tryFinally (discourse-loader:190:14) at require (discourse-loader:363:5) at eval (discourse/tests/setup-tests:256:9) at Array.forEach () at setupTestsCommon (discourse/tests/setup-tests:246:36)

Well ok I will go other way and just remove logging…

The title of this pull request changed from “DEV: disables images in headless chrome” to "DEV: suppress assets logs from qunit tests