DEV: Update ESLint to remove I18n global

DEV: Update ESLint to remove I18n global

Also fixes missed imports in core.

diff --git a/app/assets/javascripts/discourse-loader.js b/app/assets/javascripts/discourse-loader.js
index 8442f0c..d11217a 100644
--- a/app/assets/javascripts/discourse-loader.js
+++ b/app/assets/javascripts/discourse-loader.js
@@ -143,6 +143,7 @@ var define, requirejs;
         guidFor: Ember.guidFor
       },
       I18n: {
+        // eslint-disable-next-line
         default: I18n
       }
     };
diff --git a/app/assets/javascripts/discourse/app/mixins/user-fields-validation.js b/app/assets/javascripts/discourse/app/mixins/user-fields-validation.js
index 520fb8a..46051a9 100644
--- a/app/assets/javascripts/discourse/app/mixins/user-fields-validation.js
+++ b/app/assets/javascripts/discourse/app/mixins/user-fields-validation.js
@@ -2,6 +2,7 @@ import { isEmpty } from "@ember/utils";
 import EmberObject from "@ember/object";
 import discourseComputed, { on } from "discourse-common/utils/decorators";
 import Mixin from "@ember/object/mixin";
+import I18n from "I18n";
 
 export default Mixin.create({
   @on("init")
diff --git a/app/assets/javascripts/preload-application-data.js b/app/assets/javascripts/preload-application-data.js
index 0b93ded..bb11ecb 100644
--- a/app/assets/javascripts/preload-application-data.js
+++ b/app/assets/javascripts/preload-application-data.js
@@ -3,6 +3,7 @@
   const ps = require("discourse/lib/preload-store").default;
   const preloadedDataElement = document.getElementById("data-preloaded");
   const setupData = document.getElementById("data-discourse-setup").dataset;
+  const I18n = require("I18n").default;
 
   if (preloadedDataElement) {
     const preloaded = JSON.parse(preloadedDataElement.dataset.preloaded);
diff --git a/package.json b/package.json
index 1c6fb3d..c055b38 100644
--- a/package.json
+++ b/package.json
@@ -45,7 +45,7 @@
     "chrome-launcher": "^0.12.0",
     "chrome-remote-interface": "^0.25",
     "ember-template-lint": "^2.5.2",
-    "eslint-config-discourse": "1.1.1",
+    "eslint-config-discourse": "1.1.2",
     "eslint-plugin-discourse-ember": "0.0.3",
     "lodash-cli": "https://github.com/lodash-archive/lodash-cli.git",
     "pretender": "^1.6",
diff --git a/test/javascripts/acceptance/admin-user-emails-test.js b/test/javascripts/acceptance/admin-user-emails-test.js
index a9c0c2d..80c7bf4 100644
--- a/test/javascripts/acceptance/admin-user-emails-test.js
+++ b/test/javascripts/acceptance/admin-user-emails-test.js
@@ -1,3 +1,4 @@
+import I18n from "I18n";
 import { acceptance } from "helpers/qunit-helpers";
 
 acceptance("Admin - User Emails", { loggedIn: true });
diff --git a/test/javascripts/acceptance/admin-users-list-test.js b/test/javascripts/acceptance/admin-users-list-test.js
index 1c41fce..dc0d65f 100644
--- a/test/javascripts/acceptance/admin-users-list-test.js
+++ b/test/javascripts/acceptance/admin-users-list-test.js
@@ -1,3 +1,4 @@
+import I18n from "I18n";
 import { acceptance } from "helpers/qunit-helpers";
 
 acceptance("Admin - Users List", { loggedIn: true });
diff --git a/test/javascripts/acceptance/bookmarks-test.js b/test/javascripts/acceptance/bookmarks-test.js
index c2b26fb..db94c6a 100644
--- a/test/javascripts/acceptance/bookmarks-test.js
+++ b/test/javascripts/acceptance/bookmarks-test.js
@@ -1,3 +1,4 @@
+import I18n from "I18n";
 import {
   acceptance,
   loggedInUser,
diff --git a/test/javascripts/acceptance/composer-actions-test.js b/test/javascripts/acceptance/composer-actions-test.js
index 729e307..fb1a374 100644
--- a/test/javascripts/acceptance/composer-actions-test.js
+++ b/test/javascripts/acceptance/composer-actions-test.js
@@ -1,3 +1,4 @@
+import I18n from "I18n";
 import selectKit from "helpers/select-kit-helper";
 import { acceptance, updateCurrentUser } from "helpers/qunit-helpers";
 import { _clearSnapshots } from "select-kit/components/composer-actions";
diff --git a/test/javascripts/acceptance/composer-edit-conflict-test.js b/test/javascripts/acceptance/composer-edit-conflict-test.js
index 890a7df..3da144d 100644
--- a/test/javascripts/acceptance/composer-edit-conflict-test.js
+++ b/test/javascripts/acceptance/composer-edit-conflict-test.js
@@ -1,3 +1,4 @@
+import I18n from "I18n";
 import { acceptance } from "helpers/qunit-helpers";
 import pretender from "helpers/create-pretender";
 
diff --git a/test/javascripts/acceptance/composer-test.js b/test/javascripts/acceptance/composer-test.js
index 9520bd9..95fed9f 100644
--- a/test/javascripts/acceptance/composer-test.js
+++ b/test/javascripts/acceptance/composer-test.js
@@ -1,3 +1,4 @@
+import I18n from "I18n";
 import { run } from "@ember/runloop";
 import selectKit from "helpers/select-kit-helper";
 import { acceptance } from "helpers/qunit-helpers";
diff --git a/test/javascripts/acceptance/forgot-password-test.js b/test/javascripts/acceptance/forgot-password-test.js
index 773f570..c568873 100644
--- a/test/javascripts/acceptance/forgot-password-test.js
+++ b/test/javascripts/acceptance/forgot-password-test.js
@@ -1,3 +1,4 @@
+import I18n from "I18n";
 import { acceptance } from "helpers/qunit-helpers";
 
 let userFound = false;
diff --git a/test/javascripts/acceptance/group-index-test.js b/test/javascripts/acceptance/group-index-test.js
index d3ea58a..55feb15 100644
--- a/test/javascripts/acceptance/group-index-test.js
+++ b/test/javascripts/acceptance/group-index-test.js
@@ -1,3 +1,4 @@
+import I18n from "I18n";
 import { acceptance, updateCurrentUser } from "helpers/qunit-helpers";
 
 acceptance("Group Members");
diff --git a/test/javascripts/acceptance/group-test.js b/test/javascripts/acceptance/group-test.js
index 9ba5a9f..530774b 100644
--- a/test/javascripts/acceptance/group-test.js
+++ b/test/javascripts/acceptance/group-test.js
@@ -1,3 +1,4 @@
+import I18n from "I18n";
 import selectKit from "helpers/select-kit-helper";
 import { acceptance } from "helpers/qunit-helpers";
 import pretender from "helpers/create-pretender";
diff --git a/test/javascripts/acceptance/groups-new-test.js b/test/javascripts/acceptance/groups-new-test.js
index 62f88b9..aba3bca 100644
--- a/test/javascripts/acceptance/groups-new-test.js
+++ b/test/javascripts/acceptance/groups-new-test.js
@@ -1,3 +1,4 @@
+import I18n from "I18n";
 import { acceptance } from "helpers/qunit-helpers";
 
 acceptance("New Group");
diff --git a/test/javascripts/acceptance/login-with-email-and-hide-email-address-taken-test.js b/test/javascripts/acceptance/login-with-email-and-hide-email-address-taken-test.js
index 1c12c1f..e1902d7 100644
--- a/test/javascripts/acceptance/login-with-email-and-hide-email-address-taken-test.js
+++ b/test/javascripts/acceptance/login-with-email-and-hide-email-address-taken-test.js
@@ -1,3 +1,4 @@
+import I18n from "I18n";
 import { acceptance } from "helpers/qunit-helpers";
 import pretender from "helpers/create-pretender";
 
diff --git a/test/javascripts/acceptance/login-with-email-test.js b/test/javascripts/acceptance/login-with-email-test.js
index 738c292..dbc8ccc 100644
--- a/test/javascripts/acceptance/login-with-email-test.js
+++ b/test/javascripts/acceptance/login-with-email-test.js
@@ -1,3 +1,4 @@
+import I18n from "I18n";
 import { acceptance } from "helpers/qunit-helpers";
 
 let userFound = false;
diff --git a/test/javascripts/acceptance/password-reset-test.js b/test/javascripts/acceptance/password-reset-test.js
index 0bec015..be63589 100644
--- a/test/javascripts/acceptance/password-reset-test.js
+++ b/test/javascripts/acceptance/password-reset-test.js
@@ -1,3 +1,4 @@
+import I18n from "I18n";
 import { acceptance } from "helpers/qunit-helpers";
 import PreloadStore from "discourse/lib/preload-store";
 import { parsePostData } from "helpers/create-pretender";
diff --git a/test/javascripts/acceptance/personal-message-test.js b/test/javascripts/acceptance/personal-message-test.js
index b705d59..4762d45 100644
--- a/test/javascripts/acceptance/personal-message-test.js
+++ b/test/javascripts/acceptance/personal-message-test.js
@@ -1,3 +1,4 @@
+import I18n from "I18n";

[... diff too long, it was truncated ...]

GitHub sha: aa2d0405