DEV: When filter param is present, add param to nav-item hrefs (PR #10348)

GitHub

What does the fix do?

@eviltrout This commit FIX: Reset 'filter' query parameter when clicking on a nav-item by nbianca · Pull Request #10299 · discourse/discourse · GitHub

Added the filter query param in the wrong route. This moves

  queryParams: {
    filter: { refreshModel: true }
  },

to the correct route.

This pull request introduces 1 alert when merging b126184e0444d2f4e42ddbc9073b4875f569cf32 into 0b3f9638047a37bf6626bf2d6aa74299be5cd55e - view on LGTM.com

new alerts:

  • 1 for Expression has no effect

The title of this pull request changed from “FIX: Filter query param for discovery routes” to "DEV: When filter param is present, add param to nav-item hrefs

make sure we don’t pile some state between tests

could use equal

https://api.emberjs.com/ember/release/functions/@ember%2Fobject%2Fcomputed/equal

how?

lets use https://github.com/discourse/discourse/commit/eb18f91cf70feb0052b3c063283fad833623db73 for tracking state changes.