DEV: widget-dropdown CSS tweaks (#10219)

DEV: widget-dropdown CSS tweaks (#10219)

  • DEV: Remove the margin from widget-dropdown

Generic components should not have a margin. Those should be styled in the place where they are used.

  • DEV: Remove margin from the dropdown body

It triggered a warning in popper and was effectively a no-op as popper positions dropdowns on its own using position: fixed and top/right/bottom/left properties.

diff --git a/app/assets/stylesheets/common/components/widget-dropdown.scss b/app/assets/stylesheets/common/components/widget-dropdown.scss
index 8bf179d..ddc6f28 100644
--- a/app/assets/stylesheets/common/components/widget-dropdown.scss
+++ b/app/assets/stylesheets/common/components/widget-dropdown.scss
@@ -1,5 +1,4 @@
 .widget-dropdown {
-  margin: 1em;
   display: inline-flex;
   box-sizing: border-box;
 
@@ -14,7 +13,6 @@
     flex-direction: column;
     padding: 0.25em;
     background: $secondary;
-    margin-top: 5px;
     z-index: z("dropdown");
     border: 1px solid $primary-low;
     max-height: 250px;

GitHub sha: 6c91f795

This commit appears in #10219 which was approved by jjaffeux. It was merged by CvX.