Extra margin isn't needed on mobile

Extra margin isn’t needed on mobile

From a11377700339e45bbce09e96a454145b280261c2 Mon Sep 17 00:00:00 2001
From: Kris <kris.aubuchon@discourse.org>
Date: Fri, 30 Nov 2018 19:49:26 -0500
Subject: [PATCH] Extra margin isn't needed on mobile


diff --git a/app/assets/stylesheets/common/base/topic-post.scss b/app/assets/stylesheets/common/base/topic-post.scss
index 557d48d..6150468 100644
--- a/app/assets/stylesheets/common/base/topic-post.scss
+++ b/app/assets/stylesheets/common/base/topic-post.scss
@@ -509,12 +509,6 @@ aside.quote {
   }
 }
 
-// this ensures consistent top margin on topic posts even if the first line of a post
-// is a top-margin-less element like a list or image.
-.topic-body .regular {
-  margin-top: 15px;
-}
-
 .post-info {
   flex: 0 0 auto;
   margin-right: 0.5em;
diff --git a/app/assets/stylesheets/desktop/topic-post.scss b/app/assets/stylesheets/desktop/topic-post.scss
index aa86b3f..6ab671d 100644
--- a/app/assets/stylesheets/desktop/topic-post.scss
+++ b/app/assets/stylesheets/desktop/topic-post.scss
@@ -12,6 +12,11 @@ h1 .topic-statuses .topic-status .d-icon {
 }
 
 .topic-body {
+  // this ensures consistent top margin on topic posts even if the first line of a post
+  // is a top-margin-less element like a list or image.
+  .regular {
+    margin-top: 15px;
+  }
   padding: 0;
   &:first-of-type {
     border-top: none;
diff --git a/config/locales/client.en.yml b/config/locales/client.en.yml
index b062705..1bc38a5 100644
--- a/config/locales/client.en.yml
+++ b/config/locales/client.en.yml
@@ -2848,6 +2848,7 @@ en:
         activity_metrics: Activity Metrics
         all_reports: "All reports"
         general_tab: "General"
+        reports_tab: "Reports"
         moderation_tab: "Moderation"
         disabled: Disabled
         timeout_error: Sorry, query is taking too long, please pick a shorter interval

GitHub

1 Like

ah shit, didn’t mean to push this - fixing

Also, this fixes an issue where users with titles had more margin than those without on mobile

2 Likes