FEATURE: Add ability to soft delete (hide) queries and revert deletion with rake tasks (PR #54)

GitHub

The title of this pull request changed from “FEATURE: Add ability to toggle visibility for individual queries” to "FEATURE: Add ability to soft delete (hide) queries and revert deletion with rake task

This comment is useless

1 Like

This log line provides no useful information.

1 Like

This log line provides no useful information.

1 Like

The title of this pull request changed from “FEATURE: Add ability to soft delete (hide) queries and revert deletion with rake task” to "FEATURE: Add ability to soft delete (hide) queries and revert deletion with rake tasks

Perhaps we can also add a rake task for hard deletion, in case the user really wants the query gone.

This is a problem rainbow is a dependency of rubocop, it may go away and it is only there in dev and test environments.

Recommend you remove it for now, in general we don’t have any rake tasks that colorize and colorizing has its downsides (you don’t want to get weird chars in text logs)

Overall this looks nice, but is a bit light on testing, at a minimum lets test delete/undelete sequence controller action to make sure it works as expected.

1 Like

Will do, thank you