FEATURE: add expandable muted categories ui to `/categories` page. (PR #10303)

GitHub

Screenshots

image


image

This pull request has been mentioned on Discourse Meta. There might be relevant details there:

https://meta.discourse.org/t/filter-view-for-muted-categories/157956/8

you can compute on length directly

same here, you can compute on length

same here, you can compute on length

    return categories.filterBy("hasMuted");

maybe we replace “normal” and “muted” with constants?

        {{#each categories as |category|}}
          {{parent-category-row category=category showTopics=showTopics}}
            {{#each categories as |category|}}
              {{parent-category-row category=category showTopics=showTopics listType="muted"}}

can’t we give these css class ?

can we have a class instead of a here ?

can we have a class instead of a ?

can we have a class instead of h3 ?

don’t like much magic numbers in css, can we avoid this “-3px” ?

same here, could we have a class ?

can you remove clearfix here please ? Don’t think it does anything

Looks ok to me, although hard to review only on github. I would issue a warning though, as this kind of templates can be heavily overridden by plugins, di you check a little bit?