@SamSaffron they are great points. I can definitely validate the timezone, I was wondering about that as well. I think if we are setting the timezone for the user on login and it’s a bogus timezone we just leave it nil for them. And if they try to save their own bogus timezone from their profile, just pop a 422 error.
RE: moment.js issue, I think it’s a slim chance that Rails and moment.js timezone lists will become out of sync, they both use the IANA timezone list IANA — Time Zone Database. BUT if they do we could be logging when an invalid timezone is encountered for a user, so we can track down these mismatches when they do occur.
It looks like this is only set on login, will this be set when you first sign up and simply activate your account?
I’m also setting it on accept invitation, but I will set it on the registration form too.
I definitely think we will need to consider the moving around issue at some point. I guess a deferred modal on login that pops up and says “Hey, your timezone is set to Australia/Brisbane on Discourse, but it looks like you are Olé-ing in Spain right now, do you want to set your timezone to Spain/Madrid?”