FEATURE: Allow email image embed with secure media (PR #10563)

GitHub

I feel this method is a little ugly with lots of data munging, suggestions to clean up would be welcome.

Would it makes sense to have the spec check that the non-secure image here is in the markup?

Overall this looks great, just the few minor comments on the specs.

It’s not clear to me why these specs have been removed.

That makes 2 of us! Looks like it was just some merge shenanigans from those other secure media fixes I made, fixed now.

@pmusaraj yes it totally would, I will add that spec.

This pull request has been mentioned on Discourse Meta. There might be relevant details there:

https://meta.discourse.org/t/secure-media-uploads/140017/94