FEATURE: better placeholders for audio/video/trello/typeform oneboxes

FEATURE: better placeholders for audio/video/trello/typeform oneboxes

diff --git a/lib/onebox/engine/audio_onebox.rb b/lib/onebox/engine/audio_onebox.rb
index 29e4d7f..5c8e25e 100644
--- a/lib/onebox/engine/audio_onebox.rb
+++ b/lib/onebox/engine/audio_onebox.rb
@@ -21,6 +21,10 @@ module Onebox
           </audio>
         HTML
       end
+
+      def placeholder_html
+        "<div class='onebox-placeholder-container'><span class='placeholder-icon audio'></span></div>"
+      end
     end
   end
 end
diff --git a/lib/onebox/engine/trello_onebox.rb b/lib/onebox/engine/trello_onebox.rb
index c2a3deb..a13e7a6 100644
--- a/lib/onebox/engine/trello_onebox.rb
+++ b/lib/onebox/engine/trello_onebox.rb
@@ -19,6 +19,10 @@ module Onebox
         HTML
       end
 
+      def placeholder_html
+        "<div class='onebox-placeholder-container'><span class='placeholder-icon generic'></span></div>"
+      end
+
       private
       def match
         return @match if @match
diff --git a/lib/onebox/engine/typeform_onebox.rb b/lib/onebox/engine/typeform_onebox.rb
index 2b68ddd..1f7aa95 100644
--- a/lib/onebox/engine/typeform_onebox.rb
+++ b/lib/onebox/engine/typeform_onebox.rb
@@ -20,7 +20,10 @@ module Onebox
           </iframe>
         HTML
       end
-      alias placeholder_html to_html
+
+      def placeholder_html
+        "<div class='onebox-placeholder-container'><span class='placeholder-icon generic'></span></div>"
+      end
 
       private
 
diff --git a/lib/onebox/engine/video_onebox.rb b/lib/onebox/engine/video_onebox.rb
index 89c8dd7..9b894b5 100644
--- a/lib/onebox/engine/video_onebox.rb
+++ b/lib/onebox/engine/video_onebox.rb
@@ -22,6 +22,10 @@ module Onebox
           </div>
         HTML
       end
+
+      def placeholder_html
+        "<div class='onebox-placeholder-container'><span class='placeholder-icon video'></span></div>"
+      end
     end
   end
 end
diff --git a/lib/onebox/mixins/twitch_onebox.rb b/lib/onebox/mixins/twitch_onebox.rb
index b5c2719..df942e3 100644
--- a/lib/onebox/mixins/twitch_onebox.rb
+++ b/lib/onebox/mixins/twitch_onebox.rb
@@ -20,7 +20,7 @@ module Onebox
         end
 
         def placeholder_html
-          "<div class='onebox-video-placeholder'><span class='video-placeholder-icon'></span></div>"
+          "<div class='onebox-placeholder-container'><span class='placeholder-icon video'></span></div>"
         end
 
         def to_html

GitHub sha: c94e3ede

1 Like