FEATURE: better wizard privacy controls (PR #7391)

[techAPJ]

GitHub

[discoursebot]

You’ve signed the CLA, techAPJ. Thank you! This pull request is ready for review.

[coding-horror]

Screenshot?

On Wed, Apr 17, 2019 at 4:49 AM discoursebot notifications@github.com wrote:

You’ve signed the CLA, techAPJ. Thank you! This pull request is ready for review.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/discourse/discourse/pull/7391#issuecomment-484050291, or mute the thread https://github.com/notifications/unsubscribe-auth/ABc7VUeG-3KJ_aPAnJ9YN2OHpw9uOSTZks5vhwo9gaJpZM4c03I5 .

[techAPJ]

Sorry, I added it in description after creating the PR so it mustn’t had been included in email. Attaching here again.

[eviltrout]

One minor nitpick: The text for the choices is light gray, which is meant for descriptions. Primary choices should be darker. cc @awesomerobot

[awesomerobot]

app/assets/stylesheets/wizard.scss

@@ -73,6 +73,22 @@ body.wizard {
   font-weight: bold;
 }
 
+.wizard-step-privacy {
+  label[for="privacy_options"] .field-description {
+    color: #444;
+    margin-bottom: 1em;
+  }
+
+  .field-privacy-options {
+    margin-bottom: 0.8em;
+    color: #777;

I think should be all set if you just remove color: #777

[coding-horror]

when will this be ready for merge?

[techAPJ]

Currently wizard does not support a section of controls to be disabled, it either disables the whole step or none. So I’ll need to add a support for partially disabling controls. I expect it to be ready for merge early next week.