FEATURE: Check if selectable avatars exist before enabling them (PR #10032)

GitHub

Let’s enforce at least 2 avatars in the list otherwise there’s no point in enabling this feature to select just 1 avatar.

Well you could use the same avatar for everyone, but there’s no need to have a “selection” at that point… probably not worth coding for

On Fri, Jun 12, 2020 at 9:47 AM Régis Hanol notifications@github.com wrote:

@ZogStriP commented on this pull request.

In config/locales/server.en.yml https://github.com/discourse/discourse/pull/10032#discussion_r439531168:

@@ -2253,6 +2253,7 @@ en: max_username_length_exists: “You cannot set the maximum username length below the longest username (%{username}).” max_username_length_range: “You cannot set the maximum below the minimum.” invalid_hex_value: “Color values have to be 6-digit hexadecimal codes.”

  •  empty_selectable_avatars: "You must first upload selectable avatars before enabling this setting."
    

Let’s enforce at least 2 avatars in the list otherwise there’s no point in enabling this feature to select just 1 avatar.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/discourse/discourse/pull/10032#pullrequestreview-429891627, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALTWVOPZJM72IRJL4BE7ATRWJLYRANCNFSM4N3QPCMQ .

If they want to use the same avatar for everyone, then they should use the “default avatars” site setting.

“selectable avatars” should only be available where the users have a choice.

Aha yes! :+1:

On Fri, Jun 12, 2020 at 10:40 AM Régis Hanol notifications@github.com wrote:

If they want to use the same avatar for everyone, then they should use the “default avatars” site setting.

“selectable avatars” should only be available where the users have a choice.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/discourse/discourse/pull/10032#issuecomment-643402027, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALTWVIUMNPFHT42DLLXVCTRWJSCFANCNFSM4N3QPCMQ .