FEATURE: composer option to reload page and force save draft (PR #10773)

Previously when there was a draft conflict we used to show this modal:

Screenshot 2020-09-29 at 6 37 24 PM

The “OK” button was not so helpful. Now we’ll show two action buttons instead:

Screenshot 2020-09-29 at 6 42 23 PM

The “Reload” button, as expected, will reload the page. The “Ignore” button is rather interesting. If the user presses “Ignore” button the next draft save request will send force_save param as “true”. This will force the draft to be saved and will increment the draft sequence by 1.

GitHub

I am not a fan of adding boolean parameters to the end of function signatures like this, because it’s not usually clear at the call site what the parameter represents.

In this case we should prefer an opts params which is an object. Then the call site is easier to understand: { forceSave: true }

I have the same feedback as in the JS world - this would be better served by a ruby keyword argument.