FEATURE: Display new/unread count in browse more messages for PMs. (PR #14188)

GitHub

The title of this pull request changed from “WIP” to "Unread/New topics count for suggested messages in private message

This pull request introduces 2 alerts when merging 52c6bca2df32c3810aeeb9adb4cb2ee166c3a0ca into 08dce4f477b006f0bf830507aa0f75ac6c3ce895 - view on LGTM.com

new alerts:

  • 2 for Unused variable, import, function or class

This pull request introduces 2 alerts when merging 1bb85ed01daceae624e99ea7cdf8219a1e55a7eb into a2ccf0a9ff22f3e8467ac0d61f93be136bb66b31 - view on LGTM.com

new alerts:

  • 2 for Unused variable, import, function or class

This pull request introduces 2 alerts when merging 61546caf3cbc795c25d606c7adb5cb5b26bc82d4 into a2ccf0a9ff22f3e8467ac0d61f93be136bb66b31 - view on LGTM.com

new alerts:

  • 2 for Unused variable, import, function or class

The title of this pull request changed from “Unread/New topics count for suggested messages in private message” to "FEATURE: Display new/unread count in browse more messages for PMs.

@martin-brennan @davidtaylorhq Can you please review this for me? Thank you!

Sorry didn’t realize david is on holiday, @lis2 can I trouble you for a review instead?

groupName: suggestedGroupName,
        groupName: suggestedGroupName,
          groupName: suggestedGroupName,
        groupLink: this._groupLink(username, suggestedGroupName),
      const inbox =  opts.inboxFilter || this.inbox;

Is this correct? It feels like it should be unless

It looks great! I just mentioned few cosmetic adjustments

You could inject currentUser here like the other tracking state, then you won’t need to do User.current() when calling startTracking

Looks good, just a few minor changes

Could just be return if no need for nil, just a nitpick

Should be scope.user.id I think?

Good point :+1: