FEATURE: Edit bookmark reminders from post and explicit delete button (PR #9454)

There is now an explicit “Delete Bookmark” button in the edit modal:

image

A confirmation is shown before deleting

image

Along with this, when the bookmarked post icon is clicked the modal is now shown instead of just deleting the bookmark.

GitHub

The title of this pull request changed from “Feature/edit bookmark reminders from post and explicit delete” to "FEATURE: Edit bookmark reminders from post and explicit delete

The title of this pull request changed from “FEATURE: Edit bookmark reminders from post and explicit delete” to "FEATURE: Edit bookmark reminders from post and explicit delete button

I don’t think you need the word “bookmark” in the delete button? Then the copy is not unique and easier to localize. Heck maybe just use the glyph…

On Thu, Apr 16, 2020 at 7:28 PM Martin Brennan notifications@github.com wrote:

There is now an explicit “Delete Bookmark” button in the edit modal:

[image: image] https://user-images.githubusercontent.com/920448/79525638-bd796f00-80a6-11ea-8722-96addbea5b65.png

A confirmation is shown before deleting

[image: image] https://user-images.githubusercontent.com/920448/79525661-c9fdc780-80a6-11ea-80d8-b736357b5564.png

Along with this, when the bookmarked post icon is clicked the modal is now shown instead of just deleting the bookmark.

You can view, comment on, or merge this pull request online at:

https://github.com/discourse/discourse/pull/9454 Commit Summary

  • Edit bookmark with reminder functionality
  • Format reminder time in user bookmark list correctly
  • Merge branch ‘master’ into feature/allow-editing-bookmark-reminders
  • Review changes and refactors
  • Make clicking post bookmark open edit modal
  • Add explicit delete bookmark button in bookmark modal
  • Change post delete bookmark route to use bookmark manager

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/discourse/discourse/pull/9454, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALTWVOR2E7EFTWYHSWRM7TRM65EHANCNFSM4MKMNM2A .