FEATURE: favorites emojis will also show in composer autocomplete (PR #8011)

GitHub

You’ve signed the CLA, jjaffeux. Thank you! This pull request is ready for review.

This pull request has been mentioned on Discourse Meta. There might be relevant details there:

I wonder if this would be better as an ember service that’s injected? It seems to be used in components only and that would save a little code.

I notice this is EmojiStore and elsewhere it’s EmojisStore (with an s). It looks like in English it can be either emojis or emoji but we should standardize on one. I think our codebase uses “emoji” much more for the plural format so we should probably stick with that.

1 Like

Since _setup is only called here I would probably inline the function.