FEATURE: Group category permissions tab (PR #10388)

Screenshot from 2020-08-06 10-45-27


Screenshot from 2020-08-06 10-45-40

GitHub

The title of this pull request changed from “Group permissions” to "FEATURE: Group category permissions tab

Looks quite nice for a first attempt.

export default Controller.extend();

This is quite a few more lines than creating a const PERMISSION_DESCRIPTIONS = { 1: 'full', 2: 'create_post, 3: ... } then doing return I18n.t("permission_types." + PERMISSION_DESCRIPTIONS[key]);

user-content is a weird class name for something related to a group

Curious why this is necessary? By default we bootstrap the app if the request is not an XHR and don’t need to render anything specific.

        none: "There are no categories associated with this group."
        description: "Members of this group can access these categories:"

super trivial but I’d remove this blank line.

This is just the class all the group views use for the section

https://github.com/discourse/discourse/blob/1ca81fbb95ec32fce448c477cbb824e884574c93/app/assets/javascripts/discourse/app/templates/group/messages.hbs#L15

https://github.com/discourse/discourse/blob/1ca81fbb95ec32fce448c477cbb824e884574c93/app/assets/javascripts/discourse/app/templates/group/manage.hbs#L12

https://github.com/discourse/discourse/blob/1ca81fbb95ec32fce448c477cbb824e884574c93/app/assets/javascripts/discourse/app/templates/group/activity.hbs#L13

It must not be :slight_smile:

sounds good. I just moved the function to export it, but it is a good opportunity to refactor :+1: