You’ve signed the CLA, nbianca. Thank you! This pull request is ready for review.
What happens if
params[:locale] is some gibberish?
This test will fail if/when the translation changes. It’s best to call
I18n.t() with the
en locale to make this test less fragile.
Ditto about the test “fragility”
Why is this change needed? Can you add a description explaining why the change and how it solves the problem?
page < 0, then you have calculated
last for nothing
I wanted to keep all computations in one place hoping to make things more clear.
This one could also be moved near where it’s being used after the